Date: Sun, 8 Jul 2007 09:47:41 +0800 (CST) From: Tai-hwa Liang <avatar@mmlab.cse.yzu.edu.tw> To: Kostik Belousov <kostikbel@gmail.com> Cc: Jiawei Ye <leafy7382@gmail.com>, current@freebsd.org Subject: Re: HEADS UP: destroy_dev_sched() KPI in the tree Message-ID: <07070809441413.59322@www.mmlab.cse.yzu.edu.tw> In-Reply-To: <20070707160042.GJ2200@deviant.kiev.zoral.com.ua> References: <20070703180141.GJ2200@deviant.kiev.zoral.com.ua> <E1I6SAN-0000by-Bt@cs1.cs.huji.ac.il> <20070705144443.GV2200@deviant.kiev.zoral.com.ua> <c21e92e20707070536x6c8053c0l7ecad5a5bfa6de15@mail.gmail.com> <20070707160042.GJ2200@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-288813517-1183859261=:59322 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed On Sat, 7 Jul 2007, Kostik Belousov wrote: > On Sat, Jul 07, 2007 at 08:36:23PM +0800, Jiawei Ye wrote: >> On 7/5/07, Kostik Belousov <kostikbel@gmail.com> wrote: >>> >>> Today, I reverted the part of commit that tried to transform destroy_dev() >>> from d_close() into destroy_dev_sched(). See kern_conf.c, rev. 1.208. >>> You shall call destroy_dev_sched() explicitely. >>> >>> >> Does this mean that mount_smbfs has to explicitly call it now? It is >> currently stuck in the devdrn state with the latest kernel :( >> >> Jiawei Ye > Exactly. Patch by Tai-hwa Liang is pending. I also remember that sg(4) I'll ask for re@'s approval tomorrow. Hopefully the new KPI would have more exposure before my patch is committed. > had the same problem, but I do not know it current status. Though it was reviewed before destroy_dev_sched() KPI enters to the tree, I'd be appreciate it if you can reviewed the attached patch again. -- Cheers, Tai-hwa Liang --0-288813517-1183859261=:59322 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=scsi_target.c.patch Content-Transfer-Encoding: BASE64 Content-ID: <070708094741C.59322@www.mmlab.cse.yzu.edu.tw> Content-Description: Content-Disposition: attachment; filename=scsi_target.c.patch LS0tIGNhbS9zY3NpL3Njc2lfdGFyZ2V0LmMub3JpZwlXZWQgTWF5ICAyIDEx OjQyOjQ2IDIwMDcNCisrKyBjYW0vc2NzaS9zY3NpX3RhcmdldC5jCVdlZCBN YXkgIDIgMTE6NDM6MTEgMjAwNw0KQEAgLTIxMCw3ICsyMTAsNyBAQCB0YXJn Y2xvc2Uoc3RydWN0IGNkZXYgKmRldiwgaW50IGZsYWcsIGluDQogCXNvZnRj ID0gKHN0cnVjdCB0YXJnX3NvZnRjICopZGV2LT5zaV9kcnYxOw0KIAlpZiAo KHNvZnRjLT5wZXJpcGggPT0gTlVMTCkgfHwNCiAJICAgIChzb2Z0Yy0+c3Rh dGUgJiBUQVJHX1NUQVRFX0xVTl9FTkFCTEVEKSA9PSAwKSB7DQotCQlkZXN0 cm95X2RldihkZXYpOw0KKwkJZGVzdHJveV9kZXZfc2NoZWQoZGV2KTsNCiAJ CUZSRUUoc29mdGMsIE1fVEFSRyk7DQogCQlyZXR1cm4gKDApOw0KIAl9DQpA QCAtMjI5LDcgKzIyOSw3IEBAIHRhcmdjbG9zZShzdHJ1Y3QgY2RldiAqZGV2 LCBpbnQgZmxhZywgaW4NCiAJCQljYW1fcGVyaXBoX2ludmFsaWRhdGUoc29m dGMtPnBlcmlwaCk7DQogCQkJc29mdGMtPnBlcmlwaCA9IE5VTEw7DQogCQl9 DQotCQlkZXN0cm95X2RldihkZXYpOw0KKwkJZGVzdHJveV9kZXZfc2NoZWQo ZGV2KTsNCiAJCUZSRUUoc29mdGMsIE1fVEFSRyk7DQogCX0NCiAJY2FtX3Bl cmlwaF91bmxvY2socGVyaXBoKTsNCg== --0-288813517-1183859261=:59322--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?07070809441413.59322>