Date: Wed, 6 Feb 2013 21:13:07 -0500 (EST) From: Rick Macklem <rmacklem@uoguelph.ca> To: Andriy Gapon <avg@FreeBSD.org> Cc: Konstantin Belousov <kostikbel@gmail.com>, Sergey Kandaurov <pluknet@gmail.com>, FreeBSD Current <freebsd-current@FreeBSD.org> Subject: Re: panic: LK_RETRY set with incompatible flags Message-ID: <1137922035.2777364.1360203187367.JavaMail.root@erie.cs.uoguelph.ca> In-Reply-To: <51127612.8000305@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
------=_Part_2777363_1983939593.1360203187359 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Andriy Gapon wrote: > on 06/02/2013 17:15 Rick Macklem said the following: > > Well, zfs_vget() returns EOPNOTSUPP for .zfs, so the NFS server > > knows to > > switch over to using VOP_LOOKUP(). If the .zfs/snapshot and > > .zfs/share > > do the same thing, that should be fine, at least for the NFS server, > > I think. > > Ah, right, but again this is done only for .zfs and .zfs/snapshot. > .zfs/shares is not special-cased and thus is problematic here too in > the same > fashion as zfs_fhtovp. > Well, I have no way to test this, but maybe the attached patch is a start in the right direction. Maybe you can take a look at it and/or Sergey could test it? Thanks for all your help with this, rick > -- > Andriy Gapon ------=_Part_2777363_1983939593.1360203187359 Content-Type: text/x-patch; name=zfs-shares.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=zfs-shares.patch LS0tIGNkZGwvY29udHJpYi9vcGVuc29sYXJpcy91dHMvY29tbW9uL2ZzL3pmcy96ZnNfdmZzb3Bz LmMuc2F2CTIwMTMtMDItMDYgMTk6Mzg6NDEuMDAwMDAwMDAwIC0wNTAwCisrKyBjZGRsL2NvbnRy aWIvb3BlbnNvbGFyaXMvdXRzL2NvbW1vbi9mcy96ZnMvemZzX3Zmc29wcy5jCTIwMTMtMDItMDYg MjA6MDY6MzguMDAwMDAwMDAwIC0wNTAwCkBAIC0yMDA5LDcgKzIwMDksOCBAQCB6ZnNfdmdldCh2 ZnNfdCAqdmZzcCwgaW5vX3QgaW5vLCBpbnQgZmxhCiAJICogLnpmcy9zbmFwc2hvdC8gZGlyZWN0 b3JpZXMsIHRoYXQncyB3aHkgd2UgcmV0dXJuIEVPUE5PVFNVUFAuCiAJICogVGhpcyB3aWxsIG1h a2UgTkZTIHRvIHN3aXRjaCB0byBMT09LVVAgaW5zdGVhZCBvZiB1c2luZyBWR0VULgogCSAqLwot CWlmIChpbm8gPT0gWkZTQ1RMX0lOT19ST09UIHx8IGlubyA9PSBaRlNDVExfSU5PX1NOQVBESVIp CisJaWYgKGlubyA9PSBaRlNDVExfSU5PX1JPT1QgfHwgaW5vID09IFpGU0NUTF9JTk9fU05BUERJ UiB8fAorCSAgICBpbm8gPT0gemZzdmZzLT56X3NoYXJlc19kaXIpCiAJCXJldHVybiAoRU9QTk9U U1VQUCk7CiAKIAlaRlNfRU5URVIoemZzdmZzKTsKQEAgLTIwOTksMTQgKzIxMDAsMjIgQEAgemZz X2ZodG92cCh2ZnNfdCAqdmZzcCwgZmlkX3QgKmZpZHAsIGludAogCQlyZXR1cm4gKEVJTlZBTCk7 CiAJfQogCi0JLyogQSB6ZXJvIGZpZF9nZW4gbWVhbnMgd2UgYXJlIGluIHRoZSAuemZzIGNvbnRy b2wgZGlyZWN0b3JpZXMgKi8KLQlpZiAoZmlkX2dlbiA9PSAwICYmCi0JICAgIChvYmplY3QgPT0g WkZTQ1RMX0lOT19ST09UIHx8IG9iamVjdCA9PSBaRlNDVExfSU5PX1NOQVBESVIpKSB7CisJLyoK KwkgKiBBIHplcm8gZmlkX2dlbiBtZWFucyB3ZSBhcmUgaW4gLnpmcyBvciB0aGUgLnpmcy9zbmFw c2hvdAorCSAqIGRpcmVjdG9yeSB0cmVlLiBJZiB0aGUgb2JqZWN0ID09IHpmc3Zmcy0+el9zaGFy ZXNfZGlyLCB0aGVuCisJICogd2UgYXJlIGluIHRoZSAuemZzL3NoYXJlcyBkaXJlY3RvcnkgdHJl ZS4KKwkgKi8KKwlpZiAoKGZpZF9nZW4gPT0gMCAmJgorCSAgICAgKG9iamVjdCA9PSBaRlNDVExf SU5PX1JPT1QgfHwgb2JqZWN0ID09IFpGU0NUTF9JTk9fU05BUERJUikpIHx8CisJICAgIG9iamVj dCA9PSB6ZnN2ZnMtPnpfc2hhcmVzX2RpcikgewogCQkqdnBwID0gemZzdmZzLT56X2N0bGRpcjsK IAkJQVNTRVJUKCp2cHAgIT0gTlVMTCk7CiAJCWlmIChvYmplY3QgPT0gWkZTQ1RMX0lOT19TTkFQ RElSKSB7CiAJCQlWRVJJRlkoemZzY3RsX3Jvb3RfbG9va3VwKCp2cHAsICJzbmFwc2hvdCIsIHZw cCwgTlVMTCwKIAkJCSAgICAwLCBOVUxMLCBOVUxMLCBOVUxMLCBOVUxMLCBOVUxMKSA9PSAwKTsK KwkJfSBlbHNlIGlmIChvYmplY3QgPT0gemZzdmZzLT56X3NoYXJlc19kaXIpIHsKKwkJCVZFUklG WSh6ZnNjdGxfcm9vdF9sb29rdXAoKnZwcCwgInNoYXJlcyIsIHZwcCwgTlVMTCwKKwkJCSAgICAw LCBOVUxMLCBOVUxMLCBOVUxMLCBOVUxMLCBOVUxMKSA9PSAwKTsKIAkJfSBlbHNlIHsKIAkJCVZO X0hPTEQoKnZwcCk7CiAJCX0K ------=_Part_2777363_1983939593.1360203187359--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1137922035.2777364.1360203187367.JavaMail.root>