Date: Tue, 26 Feb 2008 19:16:57 -0500 From: Joe Marcus Clarke <marcus@marcuscom.com> To: amatus@gnu.org Cc: freebsd-gnome@freebsd.org Subject: Re: Question about updating guile to 1.8 Message-ID: <1204071417.28361.87.camel@shumai.marcuscom.com> In-Reply-To: <895927.27708.qm@web30003.mail.mud.yahoo.com> References: <895927.27708.qm@web30003.mail.mud.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-fmhDgenfdhbACOI77gXI Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2008-02-26 at 15:54 -0800, Amatus wrote: > --- Joe Marcus Clarke <marcus@marcuscom.com> wrote: >=20 > >=20 > > On Mon, 2008-02-25 at 14:28 -0800, Amatus wrote: > > > --- Joe Marcus Clarke <marcus@marcuscom.com> wrote: > > >=20 > > > >=20 > > > > On Mon, 2008-02-25 at 08:38 -0800, Amatus wrote: > > > > > --- Joe Marcus Clarke <marcus@marcuscom.com> wrote: > > > > >=20 > > > > > > The way you're doing it is probably best. The way you > > submitted > > > > in > > > > > > the > > > > > > PR, while it may look correct, will most likely break INDEX > > when > > > > > > guile > > > > > > is not installed. Try it. Uninstall guile, then cd to > > > > lang/slib, > > > > > > and > > > > > > run "make describe". Use of !=3D is discouraged for commands > > which > > > > are > > > > > > not in the base system. > > > > > >=20 > > > > > > Joe > > > > >=20 > > > > > I uninstalled guile and make describe worked fine with some > > noise > > > > on > > > > > stderr. > > > >=20 > > > > What output? Any output on stderr is bad. > > >=20 > > > The "make describe" outputs "/usr/local/bin/guile-config: not > > found" on > > > stderr as you might expect and the exit code is 0. Since "make > > index" > > > pipes stdout to the INDEX file everything should work fine, just > > some > > > uglyness on the user's screen. If it's really important I can try > > 2> > > > /dev/null in the command or maybe a test -f to see if the file > > exists > > > first. > >=20 > > The bigger problem is what happens to the make describe output? If > > you > > are not trying to use GUILE_VERSION in other make variables, I would > > skip the !=3D notation, and use the previous `...` notation as it is > > safer. If you use !=3D, and the make variables that reference > > GUILE_VERSION are used to in things like *_DEPENDS, then that will > > effectively break INDEX and package builds. > >=20 > > Joe > >=20 >=20 > I don't understand what the problem is. The "make describe" output on > stdout is perfectly fine, the return code is 0, and stderr goes to the > user's screen. The !=3D is necessary as far as I can tell for use in > PLIST_SUB. Though to get rid of the message on stderr I can do: Take this for instance: BUILD_DEPENDS=3D ${LOCALBASE}/share/${GUILE_VERSION}/...: ${PORTSDIR}/lang/guile GUILE_VERSION!=3D ... If guile is not installed (e.g. when pointyhat builds INDEX or prepares a portbuild) then BUILD_DEPENDS is set to: ${LOCALBASE}/share//...:${PORTSDIR}/lang/guile And that will cause things to fail. All commands must succeed and produce the correct output regardless of whether or not guile is installed. >=20 > GUILE_VER!=3D${TEST} -e ${LOCALBASE}/bin/guile-config && > ${LOCALBASE}/bin/guile-config info guileversion | ${CUT} -f 1-2 -d . || > : While this solves the problem of keeping stderr clean, it will not satisfy the requirements above. Joe >=20 >=20 >=20 >=20 > ___________________________________________________________________= _________________ > Looking for last minute shopping deals? =20 > Find them fast with Yahoo! Search. http://tools.search.yahoo.com/newsear= ch/category.php?category=3Dshopping >=20 --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-fmhDgenfdhbACOI77gXI Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iEYEABECAAYFAkfEq/gACgkQb2iPiv4Uz4cGRgCdEbcC4e/+totY3+VnyIQHLsQx 5vQAoIYT1NFDFc/Daucn84k651JDNuPc =nbch -----END PGP SIGNATURE----- --=-fmhDgenfdhbACOI77gXI--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1204071417.28361.87.camel>