Date: Thu, 12 Sep 1996 01:47:31 -0700 (PDT) From: "David E. O'Brien" <obrien@Nuxi.cs.ucdavis.edu> To: gurney_j@resnet.uoregon.edu Cc: freebsd-ports@freefall.freebsd.org Subject: Re: port of su2 Message-ID: <199609120847.BAA03410@relay.nuxi.com> In-Reply-To: <Pine.NEB.3.95.960911181626.16787n-101000@nike.efn.org> from John-Mark Gurney at "Sep 11, 96 06:20:01 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
> this program has not gone through extensive testing... but it seems to > work fine... someone might want to review the patches... but they seem > to work fine... hope this helps... ttyl... PLEASE read the handbook for how to make a FreeBSD port. I would also suggest you get almost any existing port and follow its example. Also, take a glance at /usr/share/mk/bsd.port.mk. It is *very* readable as makefiles go. 1) Your su2/Makefile does not quite follow the FreeBSD style: # New ports collection makefile for: figlet # Version required: 2.1.1 # Date created: Sat July 20, 1996 # Whom: David O'Brien (obrien@cs.ucdavis.edu) # # $Id$ # ... CATEGORIES+= sysutils 2) su2/work/su2-1.3/Makefile does *NOT* pay attention to $(PREFIX). Change $(DEST) to $(PREFIX) and this problem will be solved. (the purpose of ${PREFIX} is to allow people to easly install the program somewhere else other than /usr/local/). 3) You don't strip the su2 binary (add ``-s'' to the su2 install line in su2/work/su2-1.3/Makefile). 4) You don't compress the man page. post-install: .if !defined{NOMANCOMPRESS} gzip -9nf ${PREFIX}/man/man1/su2.1 .endif > Live in Peace, destroy Micro$oft, support free software, run FreeBSD (unix) Agreed! :-) -- David (obrien@nuxi.com)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199609120847.BAA03410>