Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 27 Mar 2001 12:45:31 +0200
From:      Jeroen Ruigrok/Asmodai <asmodai@wxs.nl>
To:        Bill Fenner <fenner@research.att.com>
Cc:        net@freebsd.org, jesper@freebsd.org, jlemon@freebsd.org
Subject:   Re: 4.3 issue: new ICMP handling broke date(1)
Message-ID:  <20010327124531.O68667@daemon.ninth-circle.org>
In-Reply-To: <200103261557.JAA08568@windsor.research.att.com>; from fenner@research.att.com on Mon, Mar 26, 2001 at 09:57:32AM -0600
References:  <200103261557.JAA08568@windsor.research.att.com>

next in thread | previous in thread | raw e-mail | index | archive | help
[making sure Jesper and Jonathan see this]

-On [20010326 18:00], Bill Fenner (fenner@research.att.com) wrote:
>Now that an ICMP port unreachable returns ENETRESET and not ECONNREFUSED,
>setting the date on the command line results in a bogusly-reported error.
>Before you fix the bug in date/netdate.c, it tends to report EADDRINUSE;
>afterwards it tends to report ENETRESET.
>
>Why did the handling of "udp port unreachable" have to change?  ECONNREFUSED
>was a perfectly fine return value for that.  I'm reasonably sure that
>there are other programs out there that think that ECONNREFUSED is what
>you get when you get an ICMP port unreachable back after a UDP send,
>so I doubt that the answer is to simply fix date(1).

FWIW I think the correct thing would be to return ECONNREFUSED.

Looking at intro(2) it would seem that ECONNREFUSED fits the shoe since
the connection is actively refused.

-- 
Jeroen Ruigrok van der Werven/Asmodai .oUo. asmodai@[wxs.nl|freebsd.org]
Documentation nutter/C-rated Coder BSD: Technical excellence at its best  
	  D78D D0AD 244D 1D12 C9CA  7152 035C 1138 546A B867
Brother, let your Heart be wounded and give no Mercy to your fear...

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010327124531.O68667>