Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 2 Apr 2002 12:21:11 +0930
From:      Greg 'groggy' Lehey <grog@FreeBSD.org>
To:        Jake Burkholder <jake@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/conf options src/sys/kern kern_ktr.c src/sys/sys ktr.h src/sys/sparc64/sparc64 genassym.c
Message-ID:  <20020402122111.A20507@wantadilla.lemis.com>
In-Reply-To: <200204010535.g315ZQQ22659@freefall.freebsd.org>
References:  <200204010535.g315ZQQ22659@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, 31 March 2002 at 21:35:26 -0800, Jake Burkholder wrote:
> jake        2002/03/31 21:35:26 PST
>
>   Modified files:
>     sys/conf             options
>     sys/kern             kern_ktr.c
>     sys/sys              ktr.h
>     sys/sparc64/sparc64  genassym.c
>   Log:
>   ktr changes to improve performance and make writing a userland utility to
>   dump the trace buffer feasible.
>   - Remove KTR_EXTEND.  This changes the format of the trace entries when
>     activated, making writing a userland tool which is not tied to a specific
>     kernel configuration difficult.
>
>   These changes will break gdb macros to decode the extended version
>   of the trace buffer which are floating around.  Users of these
>   macros should either use the show ktr command in ddb, or use the
>   userland utility which can be run on a core dump.

I really think this is wrong.  It removes a very useful debugging
tool.  IIRC it was possible to disable KTR_EXTEND when necessary.
Even if not, it was still an option, and I think it should remain one.
There are plenty of places where you won't be able to use the userland
tool.

Greg
--
See complete headers for address and phone numbers

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020402122111.A20507>