Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 30 May 2002 09:40:39 +0100
From:      Tony Finch <dot@dotat.at>
To:        Marcel Moolenaar <marcel@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/sys gpt.h
Message-ID:  <20020530094039.B10098@chiark.greenend.org.uk>
In-Reply-To: <200205300544.g4U5iN586002@freefall.freebsd.org>; from marcel@FreeBSD.org on Wed, May 29, 2002 at 10:44:23PM -0700
References:  <200205300544.g4U5iN586002@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, May 29, 2002 at 10:44:23PM -0700, Marcel Moolenaar wrote:
> 
>   o  Remove GCC specific attribute packed.
>   o  Add incomplete array padding.

Note that the padding array you have added doesn't cover the padding in
the struct that you are having trouble with: offsetof(struct gpt_hdr,
padding) == sizeof(struct gpt_hdr), i.e. there are 4 bytes of padding
before the incomplete array member. It's also a gratuitous C99ism --
a comment would be better.

Tony.
-- 
f.a.n.finch <dot@dotat.at> http://dotat.at/
FORTIES CROMARTY FORTH TYNE DOGGER: SOUTHWEST, BACKING SOUTH FOR A TIME, 4 OR
5, OCCASIONALLY 6. SHOWERS. GOOD.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020530094039.B10098>