Date: Tue, 9 Dec 2003 16:14:41 +0300 From: Yar Tikhiy <yar@FreeBSD.ORG> To: Gleb Smirnoff <glebius@cell.sick.ru>, FreeBSD-gnats-submit@FreeBSD.ORG, freebsd-bugs@FreeBSD.ORG Subject: Re: kern/47920: if ng_pppoe switches to nonstandard mode it stays in it forever Message-ID: <20031209131441.GB95449@comp.chem.msu.su> In-Reply-To: <20031209090837.GE28861@cell.sick.ru> References: <200302042232.h14MWLGj005760@virgin.v.gz.ru> <20031209090837.GE28861@cell.sick.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
I would rather change the name of the variable "nonstandard" to "pppoe_mode", not "standard", because lines like this one: standard = PPPOE_NONSTANDARD; give me a schizoid feeling :-) I also believe you should not omit the "freebsd-gnats-submit@freebsd.org" address from the list of recipients when sending a follow-up to a PR, or else GNATS will not be able to add your follow-up to the audit trail. -- Yar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031209131441.GB95449>