Date: Thu, 16 Sep 2004 04:07:45 -0000 From: Max Laier <max@love2party.net> To: pf4freebsd@freelists.org Subject: [pf4freebsd] Re: if_fxp.c.patch Message-ID: <200406222150.30587.max@love2party.net> In-Reply-To: <40D88B97.5090207@nipsi.de> References: <40D760E5.7000903@nipsi.de> <200406222003.36024.max@love2party.net> <40D88B97.5090207@nipsi.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--Boundary-02=_G2I2Atge+kSVf+S Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Tuesday 22 June 2004 21:42, Dennis Berger wrote: > Max Laier wrote: > >On Tuesday 22 June 2004 10:59, Dennis Berger wrote: > ><...> > > > >>>Spoken too quick ... I am able to reprocure and have a dump now, thanks > >>>for the head up ... I'll inform you when I have a conclusion. Thanks. > > > >Okay ... good news - should be fixed now/was not lock related at all. Bad > > news - it was plain stupidity. I forgot to check whether IFQ_DRV_DEQUEUE > > was > > so a check around IFQ_DRV_DEQUEUE was needed, why is this check needed > by the way? > does IF_DEQUEUE check this normally? No ... IF_DEQUEUE would just "always" succeed. IFQ_DEQUEUE can fail even if= =20 not IFQ_IS_EMPTY (under rate limiting e.g.). Most drivers already do this=20 check (as w/ kernel threads one could remove a packet from the queue even w= /=20 the old macros) - so maybe this can be considered a bug in if_fxp.c (which= =20 will be fixed with the altq transformation.) > >really able to give us an mbuf. > > > >Please check out the new diff and test again. Thanks and sorry. > > I'll do that Thanks =2D-=20 Best regards, | mlaier@freebsd.org Max Laier | ICQ #67774661 http://pf4freebsd.love2party.net/ | mlaier@EFnet --Boundary-02=_G2I2Atge+kSVf+S Content-Type: application/pgp-signature Content-Description: signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBA2I2GXyyEoT62BG0RAga5AJ93FK/20sadGRHCxOEJwDGgV/wvPQCeNsYV 4PkxBOPHnXvKlKMvtZ0zkM8= =pkx/ -----END PGP SIGNATURE----- --Boundary-02=_G2I2Atge+kSVf+S--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200406222150.30587.max>