Date: Mon, 30 Jan 2006 01:55:05 -0500 From: Kris Kennaway <kris@obsecurity.org> To: Jean-Yves Lefort <jylefort@FreeBSD.org> Cc: ports@freebsd.org, Alexander@Leidinger.net, mezz@freebsd.org, ru@freebsd.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: Flaw in print/acroread7 (was: Re: [ru@FreeBSD.org: [patch] mixed i386/amd64 ports semi-broken]) Message-ID: <20060130065505.GA24898@xor.obsecurity.org> In-Reply-To: <20060130071841.4aed92a2.jylefort@FreeBSD.org> References: <20060129185239.GC83362@ip.net.ua> <20060129221019.1c0a5d10@Magellan.Leidinger.net> <20060130040847.2ee8891f.jylefort@FreeBSD.org> <20060130031719.GA22430@xor.obsecurity.org> <20060130050239.485d2547.jylefort@FreeBSD.org> <20060130055838.GA24139@xor.obsecurity.org> <20060130071841.4aed92a2.jylefort@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--ew6BAiZeqk4r7MaW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Jan 30, 2006 at 07:18:41AM +0100, Jean-Yves Lefort wrote:
> > I don't see your point. The line Ruslan is removing clearly must do
> > something, otherwise it can't "fix" the affected ports. If it does
> > something, it needs to be shown that it doesn't do something bad.
>=20
> The line Ruslan is removing is a performance improvement; its purpose
> is to remove the need to execute uname -p in submakes.
OK, that sounds like "something bad" to start with. What is the time
impact on 'make index'?
> But since it
> passes ARCH as a make argument, it breaks things such as:
>=20
> .if (${ARCH} =3D=3D "amd64")
> ARCH=3D i386
> RPMFLAGS+=3D --ignorearch
> .endif
How many ports do that?
> because the ARCH=3Di386 assignment is overriden by the ARCH passed on
> the submake command line. Removing ARCH from .MAKEFLAGS should fix the
> issue without breaking ports.
Perhaps you can just do the same thing, and pass in the new ARCH to
the port build as a make argument.
Kris
--ew6BAiZeqk4r7MaW
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)
iD8DBQFD3bhJWry0BWjoQKURAqwjAJ9flyYK/2NmAVkXfSzhSFL5qjvL0gCfRfSo
OjSgC7HwQT2ZCp63ebmHCCg=
=ihXV
-----END PGP SIGNATURE-----
--ew6BAiZeqk4r7MaW--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060130065505.GA24898>