Date: Tue, 31 Jan 2006 16:08:53 -0500 From: Kris Kennaway <kris@obsecurity.org> To: Mikhail Teterin <mi+kde@aldan.algebra.com> Cc: ports@freebsd.org, Sergey Matveychuk <sem@freebsd.org> Subject: Re: ports/86310: [patch] all-depends-list target of bsd.port.mk is buggy Message-ID: <20060131210853.GA14393@xor.obsecurity.org> In-Reply-To: <200601281706.53667@aldan> References: <43DBDC93.8000505@FreeBSD.org> <200601281706.53667@aldan>
next in thread | previous in thread | raw e-mail | index | archive | help
--XsQoSWH+UP9D9v3l
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Jan 28, 2006 at 05:06:53PM -0500, Mikhail Teterin wrote:
> Actually, I think, this is an even better fix:
>=20
> --- bsd.port.mk 23 Jan 2006 22:29:26 -0000 1.523
> +++ bsd.port.mk 28 Jan 2006 22:06:23 -0000
> @@ -4582,5 +4582,5 @@
> =20
> _UNIFIED_DEPENDS=3D${EXTRACT_DEPENDS} ${PATCH_DEPENDS} ${FETCH_DEPENDS}=
=20
> ${BUILD_DEPENDS} ${LIB_DEPENDS} ${RUN_DEPENDS} ${PERL_BUILD_DEPENDS}=20
> ${PERL_RUN_DEPENDS}
> -_DEPEND_DIRS=3D ${_UNIFIED_DEPENDS:C,^[^:]*:([^:]*),\1,} ${DEPENDS:C,:.*=
,,}
> +_DEPEND_DIRS=3D ${_UNIFIED_DEPENDS:C,^[^:]*:([^:]*).*$,\1,} ${DEPENDS:C,=
:.*,,}
I have discovered a related problem, which is that when a :target is
specified e.g. in PATCH_DEPENDS, it does not correctly recurse to
discover the necessary dependencies. e.g. the cups-magicolor port has
PATCH_DEPENDS=3D ${NONEXISTENT}:${PORTSDIR}/print/cups-base:configure
but the only patch dependency added is=20
(ports-i386:~/7/ports/print/cups-magicolor)> make describe | cut -f 9 -d \|
/var/portbuild/i386/7/ports//print/cups-base
when it should go and add all the build dependencies of cups-base
(e.g. gmake), and their runtime dependencies (libiconv, etc).
I'd really appreciate if you could work on this too. For now the only
workaround is to explicitly add the full dependency list to the
affected ports by hand.
Kris
--XsQoSWH+UP9D9v3l
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)
iD8DBQFD39HlWry0BWjoQKURAmrNAKCSlHEUAaQ52vAKCZB2ENccpDlDbQCgtAOW
yquq2GoVyR/dO1DZUrkxTsE=
=NFLs
-----END PGP SIGNATURE-----
--XsQoSWH+UP9D9v3l--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060131210853.GA14393>