Date: Wed, 4 Jul 2007 21:53:15 -0500 (CDT)
From: "Sean C. Farley" <scf@FreeBSD.org>
To: Andrey Chernov <ache@nagual.pp.ru>
Cc: freebsd-current <freebsd-current@FreeBSD.org>, Robert Watson <rwatson@FreeBSD.org>, Michal Mertl <mime@traveller.cz>
Subject: Re: Environment handling broken in /bin/sh with changes to {get,set,put}env()
Message-ID: <20070704215154.O77978@thor.farley.org>
In-Reply-To: <20070704235630.GA42227@nagual.pp.ru>
References: <1183557221.1799.16.camel@genius.i.cz> <20070704143642.GA31254@nagual.pp.ru> <20070704150312.GB31683@nagual.pp.ru> <20070704101026.O77978@thor.farley.org> <20070704173905.T67251@fledge.watson.org> <20070704121316.A77978@thor.farley.org> <20070704180000.GA34042@nagual.pp.ru> <20070704144159.X77978@thor.farley.org> <20070704195939.GA35302@nagual.pp.ru> <20070704235630.GA42227@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 5 Jul 2007, Andrey Chernov wrote: > On Wed, Jul 04, 2007 at 11:59:39PM +0400, Andrey Chernov wrote: >>> Sean >>> 1. http://www.farley.org/freebsd/tmp/setenv/clearenv/ > > BTW, I think this one should _not_ free() anything according to your > comment: > > No > * previous variables are ever freed here to avoid causing a segmentation fault > * in a user's code. The latest patch at the same URL fixes that issue. It basically deactivates all existing variables and inserts the new environ variables into the envVars array. Sean -- scf@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070704215154.O77978>