Date: Thu, 5 Jul 2007 15:58:16 +0400
From: Andrey Chernov <ache@nagual.pp.ru>
To: "Sean C. Farley" <scf@FreeBSD.org>
Cc: freebsd-current <freebsd-current@FreeBSD.org>, Robert Watson <rwatson@FreeBSD.org>, Michal Mertl <mime@traveller.cz>
Subject: Re: Environment handling broken in /bin/sh with changes to {get,set,put}env()
Message-ID: <20070705115816.GA50506@nagual.pp.ru>
In-Reply-To: <20070704215154.O77978@thor.farley.org>
References: <20070704143642.GA31254@nagual.pp.ru> <20070704150312.GB31683@nagual.pp.ru> <20070704101026.O77978@thor.farley.org> <20070704173905.T67251@fledge.watson.org> <20070704121316.A77978@thor.farley.org> <20070704180000.GA34042@nagual.pp.ru> <20070704144159.X77978@thor.farley.org> <20070704195939.GA35302@nagual.pp.ru> <20070704235630.GA42227@nagual.pp.ru> <20070704215154.O77978@thor.farley.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 04, 2007 at 09:53:15PM -0500, Sean C. Farley wrote: > The latest patch at the same URL fixes that issue. It basically > deactivates all existing variables and inserts the new environ variables > into the envVars array. Calling __clean_env(false) is good but the rest looks like a bit overkill. Previously the goal of veryfy_env() is just deactivate, the goal of build_env() is just build. It was build_env() who insetrts new environ variables into envVars array in old variant, isn't? Now verify_env() takes the role of build_env() too, moreover, may cause setenv() to be called recursively which isn't good. -- http://ache.pp.ru/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070705115816.GA50506>