Date: Thu, 5 Jul 2007 17:44:44 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Danny Braniss <danny@cs.huji.ac.il> Cc: current@freebsd.org Subject: Re: HEADS UP: destroy_dev_sched() KPI in the tree Message-ID: <20070705144443.GV2200@deviant.kiev.zoral.com.ua> In-Reply-To: <E1I6SAN-0000by-Bt@cs1.cs.huji.ac.il> References: <20070703180141.GJ2200@deviant.kiev.zoral.com.ua> <E1I6SAN-0000by-Bt@cs1.cs.huji.ac.il>
next in thread | previous in thread | raw e-mail | index | archive | help
--OFtM20PmL5gDcvsL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 05, 2007 at 05:18:43PM +0300, Danny Braniss wrote: >=20 > > Today, I got re@ permission and committed the destroy_dev_sched() KPI > > into the tree. As suggested by Nate Lawson, destroy_dev() tries to > > auto-detect "devdrn" deadlock condition and transforms destroy_dev() > > from d_close() csw method into destroy_dev_sched(). I together with > > Peter Holm tried to test the change as thoroughly as possible. > >=20 > > The obvious problematic area are the races between device driver > > module unload and destroy_dev_sched(). At least smb(4) definitely > > has that race that shall be worked around by draining events with > > drain_dev_clone_events() and destroy_dev_drain(&cdevsw); see snp(4) > > change for example. > >=20 > > Please, report issues caused by the patch to the list with me Cc:ed. > > Change of autodetection of deadlock in destroy_dev() was made in separa= te > > commit for ease of reverting. >=20 > and today I got a chance to check it, and it works for me (iscsi_initiato= r). Today, I reverted the part of commit that tried to transform destroy_dev() from d_close() into destroy_dev_sched(). See kern_conf.c, rev. 1.208. You shall call destroy_dev_sched() explicitely. --OFtM20PmL5gDcvsL Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFGjQPbC3+MBN1Mb4gRAm/XAJsHjAjLcEJoqbw1ugSJDHblp5sWEwCffAaP YQsQd2TZur4rGleReWOaMfw= =ihR6 -----END PGP SIGNATURE----- --OFtM20PmL5gDcvsL--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070705144443.GV2200>