Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 14 Jul 2007 05:43:20 +0400
From:      Andrey Chernov <ache@nagual.pp.ru>
To:        "Sean C. Farley" <scf@FreeBSD.org>
Cc:        freebsd-current <freebsd-current@FreeBSD.org>
Subject:   Re: Environment handling broken in /bin/sh with changes to t,set,put}env()
Message-ID:  <20070714014319.GA24701@nagual.pp.ru>
In-Reply-To: <20070713200048.X26971@thor.farley.org>
References:  <20070708171727.GA90490@nagual.pp.ru> <20070713162742.GA16260@nagual.pp.ru> <20070713142545.K26096@thor.farley.org> <20070713202433.GA19856@nagual.pp.ru> <20070713203915.GA20270@nagual.pp.ru> <20070713171942.Q26096@thor.farley.org> <20070713224608.GB21695@nagual.pp.ru> <20070713184543.A26096@thor.farley.org> <20070714004116.GA22909@nagual.pp.ru> <20070713200048.X26971@thor.farley.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jul 13, 2007 at 08:10:33PM -0500, Sean C. Farley wrote:
>> It ends up with environ = NULL; because envVarsTotal initialized to 0
>> i.e.  makes from "environ[0] == NULL" case "environ == NULL" case
>> which is different thing.
> 
> I changed it to return (0) if either environ or environ[0] equal NULL.
> The SaveEnviron label is removed as well as the (envVarsTotal > 0)
> check.

Looks OK.

-- 
http://ache.pp.ru/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070714014319.GA24701>