Date: Sun, 2 Dec 2007 07:48:16 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Carl Shapiro <carl.shapiro@gmail.com> Cc: freebsd-current@freebsd.org, davidxu@freebsd.org Subject: Re: Serious compatibility breakage in -current. Message-ID: <20071202054815.GQ83121@deviant.kiev.zoral.com.ua> In-Reply-To: <4dcb5abd0712012042m6e6cd00br3c9e72c97f047ee5@mail.gmail.com> References: <4dcb5abd0711290226u69105089ya10526519e5cc12d@mail.gmail.com> <20071129112824.GD83121@deviant.kiev.zoral.com.ua> <4dcb5abd0711292235k2bc2af86t45f7268d429c03ad@mail.gmail.com> <20071130152631.GJ83121@deviant.kiev.zoral.com.ua> <4dcb5abd0712012042m6e6cd00br3c9e72c97f047ee5@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--l4+/aJnPlhOv5JVj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 01, 2007 at 08:42:56PM -0800, Carl Shapiro wrote: > On Nov 30, 2007 7:26 AM, Kostik Belousov <kostikbel@gmail.com> wrote: > > The patch I posted was enough for CMUCL to survive the gc. >=20 > The SIGBUS handler in CMUCL compares the value of si_code to > BUS_PAGE_FAULT. If these values do not compare equal, the signal is > not interpreted by the garbage collector. For the record, your > original patch did not fill the si_code value with BUS_PAGE_FAULT and > so it was not enough. Is this some new code ? I did tested it on CLUCL-19d compiled for RELENG_6. Also, the sigbus_handler() from lisp/FreeBSD-os.c rev 1.12 does not contain the check, it seems (that describes why it worked for me). >=20 > > Patch below shall implement it, and be MFCed to RELENG_7. The change to > > crtbrand.c shall be MFCed to RELENG_6 (and, possibly, RELENG_5). Patch > > was lightly tested on i386, and compile tested on amd64. > > Please, give it a run. >=20 > I applied your patch to my 7.0-BETA3 sources and my test programs now > behave as expected. Notably, the si_code value is always correct. > Thanks! I will put the patch into the tree ASAP, subject to coordination with re@ and portmgr@. Could you, please, describe what was tested in more details ? Did you run the CMUCL (and sbcl) with the patch ? If yes, could you, please, show the file(1) output on the bin/lisp and bin/sbcl binary ? --l4+/aJnPlhOv5JVj Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFHUkcfC3+MBN1Mb4gRAg8YAJ9kQedrtdtjo0J4Vmzf0FocKodwkwCfa+1+ ZlnYymp8CoQFw8UjL8irLFQ= =T5L7 -----END PGP SIGNATURE----- --l4+/aJnPlhOv5JVj--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071202054815.GQ83121>