Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 21 Oct 2011 14:12:21 -0700
From:      David Wolfskill <david@catwhisker.org>
To:        John Baldwin <jhb@freebsd.org>
Cc:        freebsd-current@freebsd.org
Subject:   Re: sys/conf/newvers.sh vs. subversion-1.7
Message-ID:  <20111021211221.GV59810@albert.catwhisker.org>
In-Reply-To: <201110211636.05917.jhb@freebsd.org>
References:  <20111020114844.GK59810@albert.catwhisker.org> <20111020122121.GL59810@albert.catwhisker.org> <201110211636.05917.jhb@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--zGa1rFMfQatMxgJk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 21, 2011 at 04:36:05PM -0400, John Baldwin wrote:
> ....
> I'm not sure what the best fix is.  One could possibly always run svnvers=
ion=20
> if it exists?

Sure -- and use the result as long as the exit status is 0.  (It's
certainly possible that svnversion exists, but the sources in question
aren't in a subversion working copy, after all.)

I could cobble up a patch to do that, if y'all like....

Alternatively, see the more extended comments I made to Jilles' comments
(to the PR) of a similar nature;
<http://www.freebsd.org/cgi/query-pr.cgi?pr=3D161835>.  Summary: I believe
that newvers.sh ought to be intrinsically SCM-agnostic.

Peace,
david
--=20
David H. Wolfskill				david@catwhisker.org
Depriving a girl or boy of an opportunity for education is evil.

See http://www.catwhisker.org/~david/publickey.gpg for my public key.

--zGa1rFMfQatMxgJk
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)

iEYEARECAAYFAk6h4DQACgkQmprOCmdXAD1PYQCbBW650tiMhmvHl3Ia/Qp6NEeN
0kIAn23B7XMNuPKCO62407FaL47InaQL
=PNZe
-----END PGP SIGNATURE-----

--zGa1rFMfQatMxgJk--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111021211221.GV59810>