Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 25 Oct 2013 18:46:02 +0300
From:      Konstantin Belousov <kostikbel@gmail.com>
To:        Aleksandr Rybalko <ray@freebsd.org>
Cc:        freebsd-current@freebsd.org
Subject:   Re: newcons comming
Message-ID:  <20131025154602.GJ10625@kib.kiev.ua>
In-Reply-To: <20131025160410.b0571b32440703bd9a18ead9@freebsd.org>
References:  <20131025151847.2a1b83de93335040797ceaf1@ddteam.net> <20131025160410.b0571b32440703bd9a18ead9@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--Ah9ph+G2cWRpKogL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 25, 2013 at 04:04:10PM +0300, Aleksandr Rybalko wrote:
> On Fri, 25 Oct 2013 15:18:47 +0300
> Aleksandr Rybalko <ray@ddteam.net> wrote:
>=20
> > Hello fellow hackers!
> >=20
> > I finally reach the point when I can work with newcons instead of
> > syscons on my laptop. Yes, I know it still buggy and have a lot of
> > style(9) problems. But we really have to get it into HEAD and 10.0 to
> > enable shiny new Xorg features, drivers, etc.
> >=20
> > So I ask everyone to look "hard" into that[1] and tell me your opinion.
> > I expect a lot of opinions, since it have to affect almost all good
> > guys, as result I have to ask to split "bug reports" into two parts:
> > 1. Should be done before merge to 10.0;
> > 2. Can be done later.
> >=20
> > If it possible, please do it(review - report) ASAP.
> > I have plan to done it that way:
> > 1. Merge newcons to head (in a few days);
> > 2. Fix a lot of reported bugs (2 hrs :-D );
> > 3. Persuade re@ about we need it in 10.0 (one week, maybe two);
> > 4. Merge to 10.0;
> > 5. One year AFK somewhere on Bahamas;^W^W^W^W^W^W^W
> > 5. Add mouse cut-paste support;
> > 6. Fix new bugs;
> > 7. Some drinks.
> >=20
> > What do we will have with newcons:
> > * (Think it is main) Allow us to switch to fresh Xorg, which require
> > KMS.
> > * Graphic devices which can provide framebuffer access can be easily
> > used as virtual terminals (someone may have pixel-LCD on front of PC
> > tower, may found it useful :-D )
> > * See [2].
> >=20
> > TODO:
> > * Lack of key mapping files, everyone can help with that using
> > instructions on [3];
> > * A bit slow (mostly scrolling affected).
> > * Other bugs :)
> > * See [2].
> >=20
> > Thanks!
> >=20
> > [1] - http://svnweb.freebsd.org/base/user/ed/newcons/
> > [2] -
> > http://www.freebsd.org/news/status/report-2013-07-2013-09.html#Continua=
tion-of-the-Newcons-Project
> > [3] -
> > http://raybsd.blogspot.com/2013/10/newcons-international-keyboard-input=
=2Ehtml
> >=20
> > Hope you will love newcons!
> > And maybe me too :)
> >=20
> > WBW
> > --=20
> > Aleksandr Rybalko <ray@ddteam.net>
>=20
> Forget to give a patch to HEAD, here it is:
>=20
> http://people.freebsd.org/~ray/newcons/newcons_to_head_r257107_2013-10-25=
_1542.diff.gz

Was the code reviewed by anybody ?  Was technical reviewer assigned by
the project sponsor ?

I looked very quickly over the whole patch, I only enumerate the things
that catched my eye:

dev/vt/hw/intel.c is sort of joke, it should be removed.

I am very suspicious to what you do in the drm_fb_helper.c with enqueuing,
but I need to do much more reading of the code to say something definitive.

Intel GPU might provide relatively wide range of the pixel formats, I do
not see a code to parse and use these formats.

Overall code looks relatively self-contained, so I think you indeed might
merge it to head after some public testing and review.  But I very much
doubt that 10.0 is feasible for any efforts.

--Ah9ph+G2cWRpKogL
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)

iQIcBAEBAgAGBQJSapI5AAoJEJDCuSvBvK1BsWQQAI8DxCIXbSt7n1HdPLalTyXL
KHCmXzVjhwgyrtUh8YxNifRVsMoH5d1gJmiigiFge5QibmvzKSnjYRYlccCzZ3Zf
bpc/D2VYfQ4lr5x2b8VMjiFeaHqlplnRBDG4U9W4aYa1Iz2ONz+aQpeVq6IS7OLb
9AGdS2Ni8U03Vhiptd6gsRwgbNmu8A2x/WfrD74XsZv9SZeuyrTMkHJhsl2qs6r3
ZMQQQryt3pt+Q8f9losgN+tyMrM0J5Ia7fD57o79hD1X5CpBuaClVxJ2ua+006kU
uviRvUg4Z7QewJdme2Pw0jKlvULX3w7Rjh2FjaJvBB5xTC7ALVbxqhfXRYFHJBY5
53XwQcbcyrOFpDCXjxkJUC7y7gVz9yCiU7N+amcJg7YS7wRW8bGLt4u4or5MUsBZ
GPnK1XRgMW6EOJ1kBpow6/1AvLlh1EZvLCIcr5cqCCpwf4ulQp2Bzp14EUYGuvBV
fUIrpqaN5hezyCLcCcIBN5rCGwDHEmsaPRfCaXibfHEdhq0mye1E4n5uDp8KJOox
fbGmUZXPANGyjd9HTyFWEb57XG75gqq1B5f0QxTjU0mwsvw3WftlG5GZj4MAYqG0
D2z2cQt2pFRFyG3zNoCpc5Hpz6qzUFTMsW7CJIfAyHsR5FPXRDX8HntMXiZvzR+V
Pi5WrJkG+xYuzQlc+0pS
=WrEA
-----END PGP SIGNATURE-----

--Ah9ph+G2cWRpKogL--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131025154602.GJ10625>