Date: Wed, 30 Sep 2015 16:03:28 -0400 From: Robert Blayzor <rblayzor.bulk@inoc.net> To: d@delphij.net Cc: freebsd-security@freebsd.org Subject: Re: FreeBSD Security Advisory FreeBSD-SA-15:24.rpcbind Message-ID: <20BCBD1F-D22E-4878-AB6C-CBE9F7FD4BF2@inoc.net> In-Reply-To: <560C3DF2.5070608@delphij.net> References: <20150929183942.569F311FD@freefall.freebsd.org> <B821DB04-67A9-4F7C-85E1-8ABCF72C6D46@inoc.net> <560C33B7.70100@delphij.net> <AE3C0342-75F1-4703-A685-561A303C3C76@inoc.net> <560C39B3.1020806@delphij.net> <AC5D1DD3-8AD9-49F8-9ECB-5B239E1B97F6@inoc.net> <560C3DF2.5070608@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sep 30, 2015, at 3:54 PM, Xin Li <delphij@delphij.net> wrote:
>=20
> Can you make this change and see if it helps?
>=20
> Index: rpcb_svc_com.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- rpcb_svc_com.c (revision 288421)
> +++ rpcb_svc_com.c (working copy)
> @@ -1052,7 +1052,7 @@ static bool_t
> netbuf_copybuf(struct netbuf *dst, const struct netbuf *src)
> {
>=20
> - assert(dst->buf =3D=3D NULL);
> + assert(dst->len =3D=3D 0 || dst->buf =3D=3D NULL);
=85
Same result:
Assertion failed: (dst->len =3D=3D 0 || dst->buf =3D=3D NULL), function =
netbuf_copybuf, file rpcb_svc_com.c, line 1056.
#0 0x0000000800d0164a in thr_kill () from /lib/libc.so.7
(gdb) bt
#0 0x0000000800d0164a in thr_kill () from /lib/libc.so.7
#1 0x0000000800d01636 in raise () from /lib/libc.so.7
#2 0x0000000800d015b9 in abort () from /lib/libc.so.7
#3 0x0000000800d67f31 in __assert () from /lib/libc.so.7
#4 0x00000000004073aa in ?? ()
#5 0x0000000000404075 in ?? ()
#6 0x000000000040303f in ?? ()
#7 0x000000080062a000 in ?? ()
#8 0x0000000000000000 in ?? ()
--
Robert
inoc.net!rblayzor
Jabber: rblayzor.AT.inoc.net
PGP Key: 78BEDCE1 @ pgp.mit.edu
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20BCBD1F-D22E-4878-AB6C-CBE9F7FD4BF2>