Date: Sun, 28 Oct 2001 10:55:10 +0100 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Greg Lehey <grog@FreeBSD.org> Cc: mjacob@feral.com, Jonathan Lemon <jlemon@flugsvamp.com>, "Andrey A. Chernov" <ache@nagual.pp.ru>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: Causing known breakage (was: cvs commit: src/sys/kern kern_conf.c subr_disk.c) Message-ID: <32629.1004262910@critter.freebsd.dk> In-Reply-To: Your message of "Sun, 28 Oct 2001 20:03:21 %2B1030." <20011028200321.B88146@monorchid.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20011028200321.B88146@monorchid.lemis.com>, Greg Lehey writes: >> Because it is not my task to fix all broken drivers. > >Correct. So what did you mean with the statement "That should be more >than sufficient warning for anyone."? I think getting a printf from the kernel telling you that your driver made a mistake for almost a year should be enough to spur a committer into action, no ? > I can't be bothered looking for a rule that says you shouldn't > commit anything which will knowingly cause breakage, but if it's not > in the book, it should be. First ensure that cause of the breakage > gets fixed, or fix it yourself. BZZZZZT! Wrong! -- but thanks for playing. We never had such a rule, and infrastructre changes would be close to impossible to perform if we did. Proof: Look at these messages from LINT: WARNING: COMPAT_SVR4 is broken and usage is, until fixed, not recommended #warning "The eni driver is broken and is not compiled with LINT" #warning "The fore pci driver is broken and is not compiled with LINT" #warning "The lmc driver is broken and is not compiled with LINT" This basically says that SCO/SVID compatibility, one entire ATM stack and a T1/E1 driver have been shot. This was done because somebody couldn't be bothered (according to you) or werent able to fix these drivers to use newbus or whatever it was that caused them to be disabled them. Please don't invent new rules just because you are on core and you happen to have a grudge against somebody. [*] Poul-Henning [*] Man, have I been looking forward to be in the opposite end of that argument :-) -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?32629.1004262910>