Date: Tue, 12 Jul 2016 15:10:43 +0100 From: Matthew Seaman <matthew@FreeBSD.org> To: Glen Barber <gjb@FreeBSD.org> Cc: freebsd-current@freebsd.org, FreeBSD Release Engineering Team <re@FreeBSD.org> Subject: Re: Oversight in /etc/defaults/rc.conf Message-ID: <483d186c-ca63-60ef-5703-8a7ae37e9ced@freebsd.org> In-Reply-To: <20160712122732.GA5596@FreeBSD.org> References: <f41405cb-bb41-e8f7-74eb-3dda5e3ed550@FreeBSD.org> <20160712122732.GA5596@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --dIG7RgEHRWVBhi6kdFGh5UnwE0PAFtJuN Content-Type: multipart/mixed; boundary="udR1JAiCUpeGx94cqSKAHu3FDorCOpwGU" From: Matthew Seaman <matthew@freebsd.org> To: Glen Barber <gjb@FreeBSD.org> Cc: freebsd-current@freebsd.org, FreeBSD Release Engineering Team <re@FreeBSD.org> Message-ID: <483d186c-ca63-60ef-5703-8a7ae37e9ced@freebsd.org> Subject: Re: Oversight in /etc/defaults/rc.conf References: <f41405cb-bb41-e8f7-74eb-3dda5e3ed550@FreeBSD.org> <20160712122732.GA5596@FreeBSD.org> In-Reply-To: <20160712122732.GA5596@FreeBSD.org> --udR1JAiCUpeGx94cqSKAHu3FDorCOpwGU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/12/16 13:27, Glen Barber wrote: > On Tue, Jul 12, 2016 at 07:17:19AM +0100, Matthew Seaman wrote: >> I just upgraded my main machine to 11-STABLE. Things are mostly worki= ng >> fine -- however I did notice that the new iovctl rc script is apparent= ly >> enabled by default. That seems like a trivial omission: >> >> Index: etc/defaults/rc.conf >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- etc/defaults/rc.conf (revision 302482) >> +++ etc/defaults/rc.conf (working copy) >> @@ -695,6 +695,7 @@ >> rctl_enable=3D"YES" # Load rctl(8) rules on boot >> rctl_rules=3D"/etc/rctl.conf" # rctl(8) ruleset. See rctl.conf(5). >> >> +iovctl_enable=3D"NO" >> iovctl_files=3D"" # Config files for iovctl(8) >> >> ############################################################## >> >=20 > I'm not sure I understand. Is there a functional and/or performance > impact with it enabled by default? (Note, I don't disable it in my > rc.conf, and there is no /dev/iov/* on my system.) I'm not religious about it being turned off per se. More that it should have a clearly defined on/off state shown in the defaults. I went for 'off' following the general principle that rc.conf items should mostly be off by default and require specific action to enable. Yes, there are exceptions to this rule, but I see no particular reason that iovctl should be one. What's the advantage to turning it on by default on every FreeBSD installation? However, even if it's felt it should be enabled everywhere, then shouldn't /etc/defaults/rc.conf have: iovctl_enable=3D"YES" instead? Cheers, Matthew =09 --udR1JAiCUpeGx94cqSKAHu3FDorCOpwGU-- --dIG7RgEHRWVBhi6kdFGh5UnwE0PAFtJuN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJXhPpkAAoJEABRPxDgqeTngzwP/iNBcnCZ3uVjc3cGPWOB/yyX JjuUOVNhHabaK3T6jgCoJ0+7/DqvqBqY+1lgcpmfPLLAtryOA4GLSgEuMdjzc6w9 9cqR4qQNrEEZDmofgdeuImqTGE+Fk+RHj5hEIu+E0+DFGoLOsU5QTr860HFxKkNx ozmxgRrVAlNWx/pZNbUkLAFsbTkI6j0lur33bKMzTynHXms3DQ9PJfSMND1wfZkG zNSwGRP3SxvqFMZGvhNvKgnSChQJ9cj4YqXT4aHKyQHOiaiaEA/uYV9+T3OXSmS8 96qqWF2poaMBurUJblr6vStjtfK0ZHnCw5pEgC/2kxOW106LW6usZ6JlglM8lO13 srmHM6DgaZuuLzBOak7vNZBWW/EGGwvs8qYZDbZm1tiFpnDpdGCWU0UeKul3Bp+0 YNm1JG1Z/24Fjvm4cffSihTCWDNJ/EofTgSu5pqePFZEsDxjumRty20XuzF7C7ey lsfyDGXPQSCkGqSm2Ci/GQSoynKDCtJ9iXD8e6Tkrxj/w/yfzRL9GXj+0Tp71vxs Qm0ZLIEFUYq7o23jNQxYP1huEK9b8GANfQ/BUyiHcRwXbmzJsBUSW7K7cGMzBGma ClAjaLrG0R8ktNmrRDJnivoiQsrUm9yfambKo3+5mYEsYRlWETMwzvt9bGNlALzq khAqSUo0C0JLn8DKVqR+ =PJkY -----END PGP SIGNATURE----- --dIG7RgEHRWVBhi6kdFGh5UnwE0PAFtJuN--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?483d186c-ca63-60ef-5703-8a7ae37e9ced>