Date: Wed, 18 May 2011 22:55:40 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: src-committers@FreeBSD.org, svn-src-user@FreeBSD.org Subject: Re: svn commit: r222060 - in user/avg/xcpu/sys: kern sys Message-ID: <4DD4243C.4070301@FreeBSD.org> In-Reply-To: <20110518182441.GB2273@garage.freebsd.pl> References: <201105181508.p4IF8UoS096841@svn.freebsd.org> <20110518182441.GB2273@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
on 18/05/2011 21:24 Pawel Jakub Dawidek said the following: > On Wed, May 18, 2011 at 03:08:30PM +0000, Andriy Gapon wrote: > [...] >> --- user/avg/xcpu/sys/sys/proc.h Wed May 18 15:07:36 2011 (r222059) >> +++ user/avg/xcpu/sys/sys/proc.h Wed May 18 15:08:30 2011 (r222060) >> @@ -781,7 +781,7 @@ MALLOC_DECLARE(M_SUBPROC); >> * Otherwise, the kernel will deadlock since the scheduler isn't >> * going to run the thread that holds the lock we need. >> */ >> -#define THREAD_PANICED() \ >> +#define TD_IS_INPANIC() \ >> (panicstr != NULL && (curthread->td_flags & TDF_INPANIC) != 0) > > Does TDF_INPANIC make sense without panicstr being set? Very good observation. It seems that TDF_INPANIC can never be set unless panicstr is set. So, I guess it should be OK to simplify the macro further. Thank you. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4DD4243C.4070301>