Date: Sat, 15 Jan 2011 08:32:22 -0500 From: Justin Hibbits <chmeeedalf@gmail.com> To: Andreas Tobler <andreast@FreeBSD.org> Cc: FreeBSD PowerPC ML <freebsd-ppc@FreeBSD.org> Subject: Re: fix for sysctl of DS1775 on MDD Message-ID: <7B30679E-956C-41BC-A765-EB89DB4447E9@gmail.com> In-Reply-To: <4D3158CF.7090709@FreeBSD.org> References: <DF581F3E-FA9B-427C-931C-5975AE959E74@gmail.com> <4D3158CF.7090709@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail-8--1036437443
Content-Type: text/plain;
charset=US-ASCII;
format=flowed;
delsp=yes
Content-Transfer-Encoding: 7bit
On Jan 15, 2011, at 3:20 AM, Andreas Tobler wrote:
> Hi Justin,
>
> On 14.01.11 04:36, Justin Hibbits wrote:
>> Just recompiled my kernel with the ds1775 sensor for my MDD, and
>> noticed the sensor name sysctl is blank (shows up as 'dev.ds1775.0.',
>> no sensor name), because there is no hwsensor-location property for
>> the MDD sensor. Attached is a patch that adds a generic 'cpu' name.
>> Feel free to adjust it as you see fit (checking OF_getprop return
>> instead, etc).
>
> Thanks. I put it in my testing queue.
>
> Do you have a printout from sysctl dev.ds1775?
>
> Also, I'd like to see a ofwdump -pr from the node where the ds1775
> is attached. Might be that we have another indicator than hwsensor-
> location which we could use?
>
> Gruss,
> Andreas
Ask and ye shall receive. The outputs are attached. I have both the
'before' and 'after' sysctl outputs for your reference. I looked at
the ofwdump output when making the patch, and nothing obvious jumped
out at me. I chose 'cpu' because I read online that the ds1775 is on
the CPU card for the G4 MDD. I don't know if there's any other that
has the same problem, so a default to 'cpu' seemed sufficient to me.
- Justin
--Apple-Mail-8--1036437443
Content-Disposition: attachment;
filename=dev.ds1775.output
Content-Type: application/octet-stream; x-unix-mode=0644;
name="dev.ds1775.output"
Content-Transfer-Encoding: 7bit
dev.ds1775.0.%desc: Temp-Monitor DS1775
dev.ds1775.0.%driver: ds1775
dev.ds1775.0.%location: addr=0x92
dev.ds1775.0.%pnpinfo: name=temp-monitor compat=ds1775
dev.ds1775.0.%parent: iicbus0
dev.ds1775.0.: 32.0C
--Apple-Mail-8--1036437443
Content-Disposition: attachment;
filename=dev.ds1775-after.out
Content-Type: application/octet-stream; x-unix-mode=0644;
name="dev.ds1775-after.out"
Content-Transfer-Encoding: 7bit
dev.ds1775.0.%desc: Temp-Monitor DS1775
dev.ds1775.0.%driver: ds1775
dev.ds1775.0.%location: addr=0x92
dev.ds1775.0.%pnpinfo: name=temp-monitor compat=ds1775
dev.ds1775.0.%parent: iicbus0
dev.ds1775.0.cpu: 32.5C
--Apple-Mail-8--1036437443
Content-Disposition: attachment;
filename=temp-monitor.out
Content-Type: application/octet-stream; x-unix-mode=0644;
name="temp-monitor.out"
Content-Transfer-Encoding: 7bit
Node 0xff950198: temp-monitor
name:
74 65 6d 70 2d 6d 6f 6e 69 74 6f 72 00
'temp-monitor'
device_type:
64 73 31 37 37 35 00
'ds1775'
compatible:
64 73 31 37 37 35 00
'ds1775'
built-in:
reg:
00 00 00 92
--Apple-Mail-8--1036437443--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7B30679E-956C-41BC-A765-EB89DB4447E9>