Date: Thu, 19 Jun 2008 18:54:04 -0700 From: "Garrett Cooper" <yanefbsd@gmail.com> To: "Kris Kennaway" <kris@freebsd.org> Cc: freebsd-ports@freebsd.org Subject: Re: regression-test Message-ID: <7d6fde3d0806191854o461d3bddxa44d011e56c4b73b@mail.gmail.com> In-Reply-To: <485B0A6C.3080301@FreeBSD.org> References: <676047.76296.qm@web32706.mail.mud.yahoo.com> <20080619163501.GB12160@atarininja.org> <485A921C.80602@FreeBSD.org> <20080619210519.GV18873@graf.pompo.net> <485B0A6C.3080301@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 19, 2008 at 6:39 PM, Kris Kennaway <kris@freebsd.org> wrote: > Thierry Thomas wrote: >> >> Le Jeu 19 jui 08 =E0 19:06:36 +0200, Kris Kennaway <kris@FreeBSD.org> >> =E9crivait : >> >>> We *want* regression tests to be available unconditionally -- that is w= hy >>> I added the hook to the package build process to run them if present. >>> Please don't hack around this because you think you're doing us a favo= ur >>> :-) >> >> I try to enable regression-test when possible, but the current >> implementation is a post-build target, and some ports' testings need a >> post-install target. In these cases, I enclose the regression-test >> target between .ifdef MAINTAINER_MODE. > > I'd say those ports are broken; conceptually, you should be testing wheth= er > or not your port works *before* you install it, not after. > > Kris Agreed. Functionality verification is a requirement for acceptance in any release structure, not the other way around. -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7d6fde3d0806191854o461d3bddxa44d011e56c4b73b>