Date: Mon, 10 Mar 2014 23:23:03 +0100 From: Andrew Hotlab <andrew.hotlab@hotmail.com> To: Bryan Drewery <bdrewery@freebsd.org>, "vermaden@interia.pl" <vermaden@interia.pl> Cc: "ports@freebsd.org" <ports@freebsd.org> Subject: RE: [patch] sysutils/beadm Message-ID: <DUB118-W6B066AC17E8CC6D0F2676F6740@phx.gbl> In-Reply-To: <ce46aa579d7fedfcad00a3cb9c827334@shatow.net> References: <DUB129-W68936A08892FE3CE358447F69D0@phx.gbl>, <ce46aa579d7fedfcad00a3cb9c827334@shatow.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> Date: Mon=2C 10 Mar 2014 16:11:16 -0500=0A=
> From: bdrewery@FreeBSD.org=0A=
> To: andrew.hotlab@hotmail.com=3B vermaden@interia.pl=0A=
> CC: ports@freebsd.org=0A=
> Subject: Re: [patch] sysutils/beadm=0A=
>=0A=
> On 2014-02-13 16:19=2C Andrew Hotlab wrote:=0A=
>>=0A=
>> In my setup I have the following layout (several datasets for /usr=2C=0A=
>> /var=2C etc.):=0A=
>>=0A=
>> At this moment the utility does not seems to be able to manage this=0A=
>> scheme=2C since it sets the mountpoint property as "legacy" for all=0A=
>> datasets under the root=2C thus preventing to automatically mount any=0A=
>> subdirectory at boot.=0A=
>> I've tested this simple solution (to let do the job to the canmount=0A=
>> property)=2C and it seems to solve the problem without affecting the=0A=
>> behavior when all system folders are located under a single root=0A=
>> dataset (please see the patch below). I'd be glad if you'll include it=
=0A=
>> in the next port revision.=0A=
>>=0A=
>> I'm at your disposal for any further detail.=0A=
>>=0A=
>> Best regards.=0A=
>>=0A=
>> Andrew=0A=
>>=0A=
>>=0A=
>> --- ./beadm 2014-01-11 17:08:31.112384992 +0100=0A=
>> +++ /usr/local/sbin/beadm 2014-01-11 17:06:38.620706860 +0100=0A=
>> @@ -505=2C7 +505=2C7 @@=0A=
>> if [ ${MOUNT} -eq 0 ]=0A=
>> then=0A=
>> zfs umount ${POOL}/${BEDS}/${2}=0A=
>> - zfs set mountpoint=3Dlegacy ${POOL}/${BEDS}/${2}=0A=
>> + zfs set mountpoint=3D/ ${POOL}/${BEDS}/${2}=0A=
>=0A=
> I've tested this and agree with it. It should be added upstream as it=0A=
> makes it simpler to have these extra /mounts. Otherwise you have to=0A=
> explicitly set them with mountpoint=3D/usr=2C /var=2C instead of inheriti=
ng=0A=
> from the / dataset.=0A=
> The problems I mentioned were probably before we got the 'canmount'=0A=
> support in to prevent remounting over /.=0A=
>=0A=
>> fi=0A=
>> fi=0A=
>> if ! zpool set bootfs=3D${POOL}/${BEDS}/${2} ${POOL} 1> /dev/null 2>=0A=
>> /dev/null=0A=
>> @@ -518=2C6 +518=2C7 @@=0A=
>> ZFS_LIST=3D$( zfs list -H -o name -r ${POOL}/${BEDS} )=0A=
>> # disable automatic mount on all inactive boot environments=0A=
>> echo "${ZFS_LIST}" \=0A=
>> + | grep -v "^${POOL}/${BEDS}$" \=0A=
>=0A=
> Note that this change is unrelated.=0A=
>=0A=
>> | grep -v "^${POOL}/${BEDS}/${2}$" \=0A=
>> | grep -v "^${POOL}/${BEDS}/${2}/" \=0A=
>> | while read NAME=0A=
>=0A=
=0A=
Great! I'm glad to be helpful. I'll look forward to see the change committe=
d to the Ports repository.=0A=
=0A=
Thank you so much for this wonderful tool!=0A=
=0A=
Regards.=0A=
=0A=
Andrew =
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DUB118-W6B066AC17E8CC6D0F2676F6740>