Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 25 Feb 2001 18:01:29 +1100 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        Jake Burkholder <jake@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/i386/i386 db_trace.c exception.s machdep.c trap.c src/sys/i386/include asnames.h
Message-ID:  <Pine.BSF.4.21.0102251745170.5881-100000@besplex.bde.org>
In-Reply-To: <200102250253.f1P2r6v33800@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 24 Feb 2001, Jake Burkholder wrote:

> jake        2001/02/24 18:53:06 PST
> 
>   Modified files:
>     sys/i386/i386        db_trace.c exception.s machdep.c trap.c 
>     sys/i386/include     asnames.h 
>   Log:
>   - Rename the lcall system call handler from Xsyscall to Xlcall_syscall
>     to be more like Xint0x80_syscall and less like c function syscall().

This is sort of backwards.  Xsyscall is supposed to be named like the C
function syscall(), but it should be used for normal int 0x80 syscalls.

>   - Reduce code duplication between the int0x80 and lcall handlers by
>     shuffling the elfags into the right place, saving the sizeof the
>     instruction in tf_err and jumping into the common int0x80 code.

This breaks profiling and pessimizes Xsyscall a little.  Please back this
out.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0102251745170.5881-100000>