Date: Fri, 31 May 1996 08:25:21 -0500 (EST) From: John Fieber <jfieber@indiana.edu> To: hdalog@zipnet.net Cc: scsi@FreeBSD.org Subject: Re: Archive Viper not correctly identified. Message-ID: <Pine.NEB.3.93.960531080326.12652K-100000@Fieber-John.campusview.indiana.edu> In-Reply-To: <199605311200.IAA06323@hda>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 31 May 1996, Peter Dufault wrote: > (add a "*" to the archive list) > > Right now a short name has implied spaces at the end - does an implied > "*" at the end of a short name makes more sense? Having an explicit wildcard there makes it reasonably clear to someone browsing the code how the matching is intended to work without having to read the actual matching code. Also, unless an explicit space is added after a name, you could get a false match. Imagine archive makes a viper 1500. The string "VIPER 150" would match "VIPER 1500" which may not be desired. I think requiring a * to ensure a match will be more intuitive and less prone to programmer error than requiring a trailing space to prevent a false match. (not that it would occur often, but it might...) Regardless, a more informative comment at the head of the quirk list describing the policy, and mentioning the fact that the manufacturer, model and revision fields are 8, 16 and 4 bytes respectively would be helpful to future quriklist maintainers. -john == jfieber@indiana.edu =========================================== == http://fallout.campusview.indiana.edu/~jfieber ================
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.93.960531080326.12652K-100000>