Date: Sun, 18 Jun 2006 01:37:54 +0100 (BST) From: Robert Watson <rwatson@FreeBSD.org> To: Andre Oppermann <andre@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet tcp_input.c tcp_syncache.c tcp_var.h Message-ID: <20060618013509.M67789@fledge.watson.org> In-Reply-To: <200606171732.k5HHWdl9086272@repoman.freebsd.org> References: <200606171732.k5HHWdl9086272@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 17 Jun 2006, Andre Oppermann wrote: > Revision Changes Path > 1.299 +9 -6 src/sys/netinet/tcp_input.c > 1.87 +286 -255 src/sys/netinet/tcp_syncache.c > 1.130 +9 -6 src/sys/netinet/tcp_var.h This change appears to have broken world on all architectures by exposing the mutex data structure to usr.bin/netstat/inet.c via tcp_var.h. I'm not quite sure what the "right" solution is, but if the syncache structures aren't actually used anywhere in user space, sticking them under #ifdef _KERNEL is probably a good start. The UDP and TCP monitoring code more generally suffer from the problem of exposing their internal data structures for user space monitoring purposes. Robert N M Watson Computer Laboratory University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060618013509.M67789>