Date: Sun, 31 Aug 2014 14:45:27 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-emulation@FreeBSD.org Subject: [Bug 192842] [patch][linux] linux_ppoll syscall required by linux apps that use pulseaudio (on linux_base-f20) Message-ID: <bug-192842-4075-7bHx9wYKpw@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-192842-4075@https.bugs.freebsd.org/bugzilla/> References: <bug-192842-4075@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192842 Jilles Tjoelker <jilles@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jilles@FreeBSD.org --- Comment #2 from Jilles Tjoelker <jilles@FreeBSD.org> --- Some comments about the code (I have not tested this in any way): * Look at pselect() for how to handle the signal mask. The idea of the signal mask parameter is to unblock some signals atomically with starting to wait for events on file descriptors. I think the way you are doing it, an unblocked signal will interrupt ppoll(), but will not call the signal handler. * The variable pap is not needed, you can use &pa where it is used. * Per style(9), the variable pa should be declared at the top of the function. * The less accurate timeout (ms) is probably acceptable for an emulation call like this, but it should be fixed if and when a native ppoll() is added. An overflow check may be appropriate, though: the multiplication tvp->tv_sec * 1000 may overflow and so may the addition to the sub-second part. The special case for 0 seconds is not needed. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-192842-4075-7bHx9wYKpw>