Date: Sun, 24 Apr 2016 11:33:20 +0000 From: "kristof (Kristof Provost)" <phabric-noreply@FreeBSD.org> To: freebsd-virtualization@freebsd.org Subject: [Differential] D1944: PF and VIMAGE fixes Message-ID: <fb6872e33749affbda802404df4b3332@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-clct73g5zt63yh3lvwzr-req@FreeBSD.org> References: <differential-rev-PHID-DREV-clct73g5zt63yh3lvwzr-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
kristof added inline comments. INLINE COMMENTS sys/netpfil/pf/pf_if.c:130 I don't understand why this is required. Surely if an ifnet lives in V_ifnet (so, lives in the current vnet) ifp->if_vnet is always going to be curvnet? sys/netpfil/pf/pf_if.c:141 Why add curvnet here? pfi_attach_ifnet_event doesn't use its argument. sys/netpfil/pf/pf_if.c:143 Same as above. sys/netpfil/pf/pf_if.c:151 Same as above. sys/netpfil/pf/pf_if.c:814 I believe this is correct, but should probably include adding an __unused annotation to arg, and removing the 'curvnet' argument from the EVENTHANDLER_REGISTER() call. REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, trociny, kristof, gnn, zec, rodrigc, glebius, eri Cc: ryan_timewasted.me, mmoll, javier_ovi_yahoo.com, farrokhi, julian, robak, freebsd-virtualization-list, freebsd-pf-list, freebsd-net-list
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?fb6872e33749affbda802404df4b3332>