Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 15 Jul 2014 03:11:32 +0000
From:      Steve Wills <swills@freebsd.org>
To:        Danilo Egea Gondolfo <danilo@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r361489 - head/mail/courier-pythonfilter
Message-ID:  <20140715031130.GB81490@mouf.net>
In-Reply-To: <201407102033.s6AKXYTd098971@svn.freebsd.org>
References:  <201407102033.s6AKXYTd098971@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--CUfgB8w4ZwR/yMy5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

FYI:

https://jenkins.freebsd.org/pci/head-amd64/poudriere/data/headamd64-default=
/668/logs/errors/courier-pythonfilter-1.6.log
https://jenkins.freebsd.org/pci/head-i386/poudriere/data/headi386-default/6=
68/logs/errors/courier-pythonfilter-1.6.log

=3D=3D=3D=3D>> Error: Files or directories modified:
%%LOCALSTATEDIR%% user (0, 465) gid (0, 465)
libexec/filters user (0, 465) gid (0, 465)

Seems it's touching things outside the stage dir. Could you take a look?

Thanks,
Steve

On Thu, Jul 10, 2014 at 08:33:34PM +0000, Danilo Egea Gondolfo wrote:
> Author: danilo
> Date: Thu Jul 10 20:33:34 2014
> New Revision: 361489
> URL: http://svnweb.freebsd.org/changeset/ports/361489
> QAT: https://qat.redports.org/buildarchive/r361489/
>=20
> Log:
>   - Add stage support
>   - Use @sample
>   while here
>   - Use @owner and @group
>  =20
>   PR:		ports/191521
>   Submitted by:	bsd@dino.sk
>=20
> Modified:
>   head/mail/courier-pythonfilter/Makefile
>   head/mail/courier-pythonfilter/pkg-plist
>=20
> Modified: head/mail/courier-pythonfilter/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/mail/courier-pythonfilter/Makefile	Thu Jul 10 20:30:29 2014	(r36=
1488)
> +++ head/mail/courier-pythonfilter/Makefile	Thu Jul 10 20:33:34 2014	(r36=
1489)
> @@ -20,11 +20,16 @@ MAILUID=3D	465
>  MAILGID=3D	465
> =20
>  LOCALSTATEDIR=3D	/var/spool/courier
> -SCRIPTSDIR=3D	${PREFIX}/libexec/filters
> +PYSCRIPTSDIR=3D	${PREFIX}/libexec/filters
> +
> +PLIST_SUB+=3D	MAILOWN=3D"${MAILOWN}" MAILGRP=3D"${MAILGRP}" \
> +		MAILUID=3D"${MAILUID}" MAILGID=3D"${MAILGID}" \
> +		LOCALSTATEDIR=3D"${LOCALSTATEDIR}"
> +SUB_LIST+=3D	${PLIST_SUB}
> =20
>  OPTIONS_DEFINE=3D	DEBUG NODUPLICATES LOCALSENDERS SPAMASSASSIN AUTO_WHIT=
ELIST WHITELIST_RELAY WHITELIST_AUTH \
>  		WHITELIST_BLOCK WHITELIST_DNSWL WHITELIST_DNSWL DELIVEREDTO PRIVATEADD=
R SPFCHECK NOSUCCESSDSN \
> -		COMEAGAIN GREYLIST DIALBACK RATELIMIT ATTACHMENTS QUOTA
> +		COMEAGAIN GREYLIST DIALBACK RATELIMIT ATTACHMENTS QUOTA WHITELIST_SPF
> =20
>  DEBUG_DESC=3D	debug module
>  NODUPLICATES_DESC=3D	noduplicates module
> @@ -37,7 +42,7 @@ WHITELIST_RELAY_DESC=3D	whitelist_relaycli
>  WHITELIST_AUTH_DESC=3D	whitelist_auth module
>  WHITELIST_BLOCK_DESC=3D	whitelist_block module
>  WHITELIST_DNSWL_DESC=3D	whitelist_dnswl module
> -WHITELIST_SP_DESC=3D	Fwhitelist_spf module
> +WHITELIST_SP_DESC=3D	whitelist_spf module
>  DELIVEREDTO_DESC=3D	deliveredto module
>  PRIVATEADDR_DESC=3D	privateaddr module
>  SPFCHECK_DESC=3D	spfcheck module
> @@ -55,10 +60,9 @@ RG1_DESC=3D	ClamAV Filter Option
> =20
>  OPTIONS_DEFAULT=3D	DEBUG WHITELIST_RELAY WHITELIST_AUTH
> =20
> -NO_STAGE=3D	yes
>  .include <bsd.port.pre.mk>
> =20
> -PYDISTUTILS_INSTALLARGS:=3D${PYDISTUTILS_INSTALLARGS} --install-scripts=
=3D${SCRIPTSDIR}
> +PYDISTUTILS_INSTALLARGS:=3D${PYDISTUTILS_INSTALLARGS} --install-scripts=
=3D${PYSCRIPTSDIR}
> =20
>  .if ${PORT_OPTIONS:MCLAMAV_CLAMD} && ! ${PORT_OPTIONS:MCLAMAV_LIB}
>  RUN_DEPENDS+=3D	${PYTHON_SITELIBDIR}/pyclamd.py:${PORTSDIR}/security/py-=
pyclamd
> @@ -143,9 +147,6 @@ post-patch:
>  	@${REINPLACE_CMD} -e 's|%%PREFIX%%|${PREFIX}|g' ${WRKSRC}/pythonfilter
> =20
>  post-install:
> -	${MKDIR} ${LOCALSTATEDIR}/pythonfilter
> -	${CHOWN} ${MAILOWN}:${MAILGRP} ${LOCALSTATEDIR}/pythonfilter
> -	@if [ ! -f ${PREFIX}/etc/pythonfilter.conf ]; then cp -p ${PREFIX}/etc/=
pythonfilter.conf.sample ${PREFIX}/etc/pythonfilter.conf; fi
> -	@if [ ! -f ${PREFIX}/etc/pythonfilter-modules.conf ]; then cp -p ${PREF=
IX}/etc/pythonfilter-modules.conf.sample ${PREFIX}/etc/pythonfilter-modules=
=2Econf; fi
> +	@${MKDIR} ${STAGEDIR}${LOCALSTATEDIR}/pythonfilter
> =20
>  .include <bsd.port.post.mk>
>=20
> Modified: head/mail/courier-pythonfilter/pkg-plist
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/mail/courier-pythonfilter/pkg-plist	Thu Jul 10 20:30:29 2014	(r3=
61488)
> +++ head/mail/courier-pythonfilter/pkg-plist	Thu Jul 10 20:33:34 2014	(r3=
61489)
> @@ -1,9 +1,5 @@
> -@unexec if cmp -s %D/etc/pythonfilter.conf %D/etc/pythonfilter.conf.samp=
le; then rm -f %D/etc/pythonfilter.conf; fi
> -etc/pythonfilter.conf.sample
> -@exec if [ ! -f %D/etc/pythonfilter.conf ]; then cp -p %D/etc/pythonfilt=
er.conf.sample %D/etc/pythonfilter.conf; fi
> -@unexec if cmp -s %D/etc/pythonfilter-modules.conf %D/etc/pythonfilter-m=
odules.conf.sample; then rm -f %D/etc/pythonfilter-modules.conf; fi
> -etc/pythonfilter-modules.conf.sample
> -@exec if [ ! -f %D/etc/pythonfilter-modules.conf ]; then cp -p %D/etc/py=
thonfilter-modules.conf.sample %D/etc/pythonfilter-modules.conf; fi
> +@sample etc/pythonfilter.conf.sample
> +@sample etc/pythonfilter-modules.conf.sample
>  libexec/filters/pythonfilter
>  libexec/filters/pythonfilter-quarantine
>  %%PYTHON_SITELIBDIR%%/courier/__init__.py
> @@ -102,5 +98,17 @@ libexec/filters/pythonfilter-quarantine
>  %%PYTHON_SITELIBDIR%%/pythonfilter/whitelist_spf.py
>  %%PYTHON_SITELIBDIR%%/pythonfilter/whitelist_spf.pyc
>  %%PYTHON_SITELIBDIR%%/pythonfilter/whitelist_spf.pyo
> +%%PYTHON_SITELIBDIR%%/courier_pythonfilter-1.6-py2.7.egg-info/PKG-INFO
> +%%PYTHON_SITELIBDIR%%/courier_pythonfilter-1.6-py2.7.egg-info/SOURCES.txt
> +%%PYTHON_SITELIBDIR%%/courier_pythonfilter-1.6-py2.7.egg-info/dependency=
_links.txt
> +%%PYTHON_SITELIBDIR%%/courier_pythonfilter-1.6-py2.7.egg-info/top_level.=
txt
> +@owner courier
> +@group courier
> +@dirrmtry %%LOCALSTATEDIR%%/pythonfilter
> +@group courier
> +@owner courier
> +@dirrmtry %%LOCALSTATEDIR%%
>  @dirrm %%PYTHON_SITELIBDIR%%/courier
>  @dirrm %%PYTHON_SITELIBDIR%%/pythonfilter
> +@dirrm %%PYTHON_SITELIBDIR%%/courier_pythonfilter-1.6-py2.7.egg-info
> +@dirrmtry libexec/filters

--CUfgB8w4ZwR/yMy5
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJTxJviAAoJEPXPYrMgexuhuggH/2nQpG/zD28GZj1U3XPBdevq
q+Zwv4vObIaz7wgcDVO3HQyDjUhEjAndR463Xb7Ec1cFZH1lzmRSSg//O/uZLFnc
kS6fwQF+aLwaYUha0ux8Jt3cLqdnFSjpjB3w2SoMQzkIIq6+0AF5PUGVWgVoE2be
6wmAAh14H3roGN6IgrdZ0h1jqxSvXq/7JNfPiBjsZGg2sQCtvtmpVgK+6dyZAs+p
cvTh+X4vMPW2Mi4XbPyTUqJccks5LYImMNWtZpBi/w4zp10BmfiGS0zhmgsVxTRV
SlZrdWW/Yiq5UrfKdGe5qNda09aaLiT0QETPrkEXNVuqnVOCsWUtJ3DnLgy47oM=
=jN4o
-----END PGP SIGNATURE-----

--CUfgB8w4ZwR/yMy5--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140715031130.GB81490>