Skip site navigation (1)Skip section navigation (2)
Date:      25 Nov 2000 20:13:22 -0000
From:      mwm@mired.org
To:        FreeBSD-gnats-submit@freebsd.org
Subject:   misc/23094: The PR system has no way to let committers know that a PR includes commitable code
Message-ID:  <20001125201322.75768.qmail@guru.mired.org>

next in thread | raw e-mail | index | archive | help

>Number:         23094
>Category:       misc
>Synopsis:       The PR system has no way to let committers know that a PR includes commitable code
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Nov 25 12:20:01 PST 2000
>Closed-Date:
>Last-Modified:
>Originator:     Mike Meyer
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
Meyer Consulting
>Environment:
System: FreeBSD guru.mired.org 5.0-CURRENT FreeBSD 5.0-CURRENT #0: Sun Nov 19 06:16:20 CST 2000 mwm@guru.mired.org:/usr/obj/sharetmp/src/sys/GURU i386

>Description:

It seems that PR's that include source - patches to fix the problem,
new documentation, new code - can sit in the PR queue for months on
end. While this is understandable for PRs that require debugging, a PR
that just needs to be audited and committed should either be commited
or rejected in fairly short order.

>How-To-Repeat:

Try submitting PRs and tracking how many get dealt with less than a
month, vs. how many get ignored for the same period of time. My
numbers have > 50% being ignored, and a fair percentage of the rest
drawing a comment or two, and *then* sitting unresolved.

>Fix:

Adding some kind of "contains committable material" indicator to the
PR would allow committers to easily find - and deal with - PRs where
the user has provided an immediate contribution, as opposed to just a
bug report. Maybe a one-line "Fix" field that has options like
"bug-report; suggestion; tested patch; new code; new docs".


>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001125201322.75768.qmail>