Date: Wed, 16 Jul 2014 09:56:52 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Kurt Jaeger <pi@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r361987 - in head/security: . signify signify/files Message-ID: <20140716095652.GB53961@FreeBSD.org> In-Reply-To: <201407151748.s6FHmep9006450@svn.freebsd.org> References: <201407151748.s6FHmep9006450@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 15, 2014 at 05:48:40PM +0000, Kurt Jaeger wrote: > New Revision: 361987 > URL: http://svnweb.freebsd.org/changeset/ports/361987 > QAT: https://qat.redports.org/buildarchive/r361987/ > > Log: > New port: security/signify > > 'signify' from OpenBSD as of July 15 2014, with the necessary plumbing > cobbled together from the OpenBSD CVS to make it compile under Linux. Sorry, but this is very poor work. > +COMMENT= OpenBSD signify ported by fefe Who/what is "fefe"? Organization, person, robot, a giant mushroom? > +do-install: > + ${CP} ${WRKSRC}/signify ${STAGEDIR}${PREFIX}/bin Why INSTALL_PROGRAM was not used instead? It does some nice things like ensuring correct permissions and stripping of executables. > +-CC=gcc -D_GNU_SOURCE -D_BSD_SOURCE -DHAVE_SYS_SYSCALL_H > ++CC=clang -D_GNU_SOURCE -D_BSD_SOURCE -DHAVE_SYS_SYSCALL_H You realise that there are FreeBSD releases that are still GCC-based? Why clang is even required for this port? Even if it is (which I really doubt) it should've been set via MAKE_ARGS instead of the privial patch file, and correct USES=compiler:... provided as well. > + CFLAGS=-Os -pipe We generally try to uphold our CFLAGS (also easier to do via MAKE_ARGS than to patch Makefile in simple cases like this one). > +++ head/security/signify/pkg-plist Tue Jul 15 17:48:40 2014 (r361987) > @@ -0,0 +1 @@ > +bin/signify One-line pkg-plist, in 2014? (Hint: PLIST_FILES). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140716095652.GB53961>