Date: Sun, 12 Feb 2006 02:49:12 -0500 From: Joe Marcus Clarke <marcus@marcuscom.com> To: Khairil Yusof <khairil.yusof@gmail.com> Cc: gnome@freebsd.org, jylefort@freebsd.org, ssouhlal@freebsd.org Subject: Re: problems rhythmbox 0.9.3.1 Message-ID: <1139730552.91280.4.camel@shumai.marcuscom.com> In-Reply-To: <1139726108.12426.18.camel@shumai.marcuscom.com> References: <1139185642.25725.167.camel@wolverine> <1139187760.730.10.camel@shumai.marcuscom.com> <1139647425.79253.4.camel@shumai.marcuscom.com> <1139674838.37533.78.camel@wolverine> <1139685927.59900.1.camel@shumai.marcuscom.com> <1139713316.37533.84.camel@wolverine> <1139713404.59900.36.camel@shumai.marcuscom.com> <1139726108.12426.18.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-GN2L6R/6URKpA2Rswm7l Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sun, 2006-02-12 at 01:35 -0500, Joe Marcus Clarke wrote: > On Sat, 2006-02-11 at 22:03 -0500, Joe Marcus Clarke wrote: > > On Sun, 2006-02-12 at 11:01 +0800, Khairil Yusof wrote: > > > On Sat, 2006-02-11 at 14:25 -0500, Joe Marcus Clarke wrote: > > >=20 > > > > And I am also loading songs over NFS....hmmm. What FAM system are = you > > > > using? > > >=20 > > > gamin with WANT_FAM_SYSTEM=3Dgamin in /etc/make.conf > >=20 > > You should be setting WITH_FAM_SYSTEM in make.conf now. In any event, > > I'm using gamin as well. >=20 > I found the problem. Since gamin is looking at NOTE_ATTRIB for changes, > even a file access change will trigger a FAM changed event. And since > such an event triggers a reload of the changed file in r-b, the > attributes change again, and then r-b loads the file again, ... and so > on. >=20 > It seems to me r-b is being too aggressive in what it considers a > change. I think a good solution might be to change > rhythmdb_check_changed_file() in rhythmdb.c to always return TRUE. This > will remove the "changed" file from the list of changed files, and it > should never trigger this cycle. >=20 > I'll give this a try, and let you know. Sorry, this doesn't work. On closer inspection, all events would be ignored by r-b if this was done. I've copied Jean-Yves and Suleiman on this to get their opinion. I checked how Linux's inotify works, and they have separate events for st_atime changing vs. other attributes (IN_ACCESS vs. IN_ATTRIB). Perhaps we should do something similar. In the meantime, the best solutions I can come up with are to disable NOTE_ATTRIB processing in gamin, or turn off library monitoring in rhythmbox. Joe --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-GN2L6R/6URKpA2Rswm7l Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBD7uh4b2iPiv4Uz4cRAsOyAJwOMWzrjwnTSAUokGUuHrjFRWdWbwCfSzb7 Jd4OWnhWukbRmQ5fVAdrtAM= =Xfjy -----END PGP SIGNATURE----- --=-GN2L6R/6URKpA2Rswm7l--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1139730552.91280.4.camel>