Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 5 Nov 2013 13:36:05 +0000 (UTC)
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r257701 - head/usr.sbin/pkg
Message-ID:  <201311051336.rA5Da5Cw082080@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: bdrewery (ports committer)
Date: Tue Nov  5 13:36:05 2013
New Revision: 257701
URL: http://svnweb.freebsd.org/changeset/base/257701

Log:
  Remove condition which can never be true as the previous loop
  is never exited while remote == NULL.
  
  Reported by:	Coverity
  Approved by:	bapt
  MFC after:	2 days

Modified:
  head/usr.sbin/pkg/pkg.c

Modified: head/usr.sbin/pkg/pkg.c
==============================================================================
--- head/usr.sbin/pkg/pkg.c	Tue Nov  5 12:55:28 2013	(r257700)
+++ head/usr.sbin/pkg/pkg.c	Tue Nov  5 13:36:05 2013	(r257701)
@@ -233,9 +233,6 @@ fetch_to_fd(const char *url, char *path)
 		}
 	}
 
-	if (remote == NULL)
-		goto fetchfail;
-
 	while (done < st.size) {
 		if ((r = fread(buf, 1, sizeof(buf), remote)) < 1)
 			break;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201311051336.rA5Da5Cw082080>