Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 23 Jul 2005 00:15:30 GMT
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 80823 for review
Message-ID:  <200507230015.j6N0FULq051216@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=80823

Change 80823 by rwatson@rwatson_zoo on 2005/07/23 00:14:42

	Un-comment bug now fixed.

Affected files ...

.. //depot/projects/netsmp/src/sys/netinet/in.c#3 edit

Differences ...

==== //depot/projects/netsmp/src/sys/netinet/in.c#3 (text+ko) ====

@@ -985,12 +985,6 @@
 		return ifma->ifma_protospec;
 	}
 
-	/* XXX - if_addmulti uses M_WAITOK.  Can this really be called
-	   at interrupt time?  If so, need to fix if_addmulti. XXX */
-	/*
-	 * XXXRW: This comment is right, and yes, we should use M_NOWAIT
-	 * here due to spl's and now mutexes.
-	 */
 	inm = (struct in_multi *)malloc(sizeof(*inm), M_IPMADDR,
 	    M_NOWAIT | M_ZERO);
 	if (inm == NULL) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200507230015.j6N0FULq051216>