Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 9 Mar 2013 13:05:21 +0000 (UTC)
From:      Davide Italiano <davide@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r248099 - head/sys/fs/smbfs
Message-ID:  <201303091305.r29D5LDA060076@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: davide
Date: Sat Mar  9 13:05:21 2013
New Revision: 248099
URL: http://svnweb.freebsd.org/changeset/base/248099

Log:
  - Initialize variable in smbfs_rename() to silent compiler warning
  - Fix smbfs_mkdir() return value (in case of error).
  
  Reported by:	pho

Modified:
  head/sys/fs/smbfs/smbfs_vnops.c

Modified: head/sys/fs/smbfs/smbfs_vnops.c
==============================================================================
--- head/sys/fs/smbfs/smbfs_vnops.c	Sat Mar  9 12:51:39 2013	(r248098)
+++ head/sys/fs/smbfs/smbfs_vnops.c	Sat Mar  9 13:05:21 2013	(r248099)
@@ -580,6 +580,7 @@ smbfs_rename(ap)
 	u_int16_t flags = 6;
 	int error=0;
 
+	scred = NULL;
 	/* Check for cross-device rename */
 	if ((fvp->v_mount != tdvp->v_mount) ||
 	    (tvp && (fvp->v_mount != tvp->v_mount))) {
@@ -730,7 +731,7 @@ smbfs_mkdir(ap)
 	*ap->a_vpp = vp;
 out:
 	smbfs_free_scred(scred);
-	return 0;
+	return error;
 }
 
 /*



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201303091305.r29D5LDA060076>