Date: Tue, 8 Jun 2010 23:31:26 -0700 From: Greg Lewis <glewis@eyesbeyond.com> To: "Philip M. Gollucci" <pgollucci@p6m7g8.com> Cc: Rob Farmer <rfarmer@predatorlabs.net>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, glewis@FreeBSD.org, Ion-Mihai Tetcu <itetcu@FreeBSD.org> Subject: Re: cvs commit: ports/java/jdk16 Makefile Message-ID: <20100609063126.GA96306@misty.eyesbeyond.com> In-Reply-To: <4C0F146C.3060906@p6m7g8.com> References: <201006082017.o58KHb1o039986@repoman.freebsd.org> <AANLkTik3R8LnuLk9NgrPHWkjntu_ufRaSkkdw5AzG--z@mail.gmail.com> <4C0EB5E8.5040009@p6m7g8.com> <20100609004757.7a61d6f6@it.buh.tecnik93.com> <20100609035149.GA94751@misty.eyesbeyond.com> <4C0F146C.3060906@p6m7g8.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 09, 2010 at 12:11:24AM -0400, Philip M. Gollucci wrote:
> On 6/8/2010 11:51 PM, Greg Lewis wrote:
> > The build uses the following logic to detect the presence of sigignore:
> >
> > ifeq ($(OS_VENDOR),FreeBSD)
> > OS_RELDATE := $(shell sysctl kern.osreldate | cut -d' ' -f2)
> > HAS_SIGIGNORE := $(shell if [ $(OS_RELDATE) -ge 800502 -a $(OS_RELDATE) -lt 900000 -o $(OS_RELDATE) -ge 900003 ]; then echo "1"; fi)
> > ifeq ($(HAS_SIGIGNORE),1)
> > override HAVE_SIGIGNORE = true
> > endif
> > endif
> >
>
> Why not do something like what devel/apr1 does:
>
> patch the file to be %%OSVERSION%% here, then in post-patch replace that
> token with the value. OSVERSION is overloaded correctly on pointyhat
> and tb(hence QAT) whereas sysctl is not.
>
>
> post-patch:
> ${REINPLACE_CMD} -e 's/OSVERSION/${OSVERSION}/g' \
> ${APR_WRKDIR}/build/apr_hints.m4
Thanks. I've committed a change to do this.
If someone could please let me know if you see any problems (I don't have
a box which actually has a recent 8-STABLE or 9-CURRENT I can test on) that
would be great. It seems to still do the right thing on versions without
sigignore(3) at least.
It would also be good to know if QAT is now happy with it.
--
Greg Lewis Email : glewis@eyesbeyond.com
Eyes Beyond Web : http://www.eyesbeyond.com
Information Technology FreeBSD : glewis@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100609063126.GA96306>