Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 15 Jun 2010 00:22:27 +0200
From:      Luigi Rizzo <rizzo@iet.unipi.it>
To:        Ermal Lu?i <eri@freebsd.org>
Cc:        freebsd-net <freebsd-net@freebsd.org>, Luigi Rizzo <luigi@freebsd.org>
Subject:   Re: [PATCH] ipfw pipe bandwidth parameter parser.
Message-ID:  <20100614222227.GA98913@onelab2.iet.unipi.it>
In-Reply-To: <AANLkTina6_2EoZOVPWD3pPcJ4FbeDi8eahcHXp-KL-XN@mail.gmail.com>
References:  <AANLkTina6_2EoZOVPWD3pPcJ4FbeDi8eahcHXp-KL-XN@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 14, 2010 at 11:01:43PM +0100, Ermal Lu?i wrote:
> Hello,
> 
> on FreeBSD-STABLE at least ipfw wrongly interprets dummynet
> configurations of the type:
> 
> pipe 10 config bw 1.5Mb
>                            ^^^

Given that there is an easy workaround (use bw 1500Kbit/s)
i'd probably just leave it alone, at least for 8.1

I think this behaviour (only accepting integers before the unit)
has been there forever, and is one of the many things broken in
the code that parses bandwidth, sizes and delays.
I am slightly afraid of fixing it because people might have
(broken) configurations relying on undocumented behaviour.

cheers
luigi



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100614222227.GA98913>