Date: Mon, 14 Jun 2010 15:49:17 -0700 From: Julian Elischer <julian@elischer.org> To: Luigi Rizzo <rizzo@iet.unipi.it> Cc: Ermal Lu?i <eri@freebsd.org>, freebsd-net <freebsd-net@freebsd.org>, Luigi Rizzo <luigi@freebsd.org> Subject: Re: [PATCH] ipfw pipe bandwidth parameter parser. Message-ID: <4C16B1ED.7000204@elischer.org> In-Reply-To: <20100614222227.GA98913@onelab2.iet.unipi.it> References: <AANLkTina6_2EoZOVPWD3pPcJ4FbeDi8eahcHXp-KL-XN@mail.gmail.com> <20100614222227.GA98913@onelab2.iet.unipi.it>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6/14/10 3:22 PM, Luigi Rizzo wrote: > On Mon, Jun 14, 2010 at 11:01:43PM +0100, Ermal Lu?i wrote: >> Hello, >> >> on FreeBSD-STABLE at least ipfw wrongly interprets dummynet >> configurations of the type: >> >> pipe 10 config bw 1.5Mb >> ^^^ > > Given that there is an easy workaround (use bw 1500Kbit/s) > i'd probably just leave it alone, at least for 8.1 > > I think this behaviour (only accepting integers before the unit) > has been there forever, and is one of the many things broken in > the code that parses bandwidth, sizes and delays. > I am slightly afraid of fixing it because people might have > (broken) configurations relying on undocumented behaviour. the answer may be to just doccument it properly. then it is DOCUMENTED behaviour. > > cheers > luigi > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C16B1ED.7000204>