Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 15 Dec 2013 18:01:18 +0000 (UTC)
From:      Marcel Moolenaar <marcel@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   svn commit: r259419 - projects/altix2/sys/sparc64/include
Message-ID:  <201312151801.rBFI1IwM020208@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: marcel
Date: Sun Dec 15 18:01:18 2013
New Revision: 259419
URL: http://svnweb.freebsd.org/changeset/base/259419

Log:
  Bump BUS_SPACE_MAXADDR from 2^31-1 to 2^64-1. The bus_dma compat layer
  panics, because it checks that the maximum address passed to
  bus_dma_tag_create() matches BUS_SPACE_MAXADDR and finds that it doesn't
  for psycho(4). The psycho(4) driver passes ~0 and not BUS_SPACE_MAXADDR.
  sparc64 is a 64-bit archirecture, so why isn't BUS_SPACE_MAXADDR 2^61-1?
  
  I'm probably groing to regret this change, but so far it doesn't look
  like it's having any negative side-effects.
  
  While here, postfix U and UL to the BUS_SPACE constants.

Modified:
  projects/altix2/sys/sparc64/include/bus.h

Modified: projects/altix2/sys/sparc64/include/bus.h
==============================================================================
--- projects/altix2/sys/sparc64/include/bus.h	Sun Dec 15 16:58:23 2013	(r259418)
+++ projects/altix2/sys/sparc64/include/bus.h	Sun Dec 15 18:01:18 2013	(r259419)
@@ -94,11 +94,11 @@ extern const int bus_stream_asi[];
 #define	__BUS_SPACE_HAS_STREAM_METHODS	1
 
 #define	BUS_SPACE_MAXSIZE_24BIT	0xFFFFFF
-#define	BUS_SPACE_MAXSIZE_32BIT 0xFFFFFFFF
-#define	BUS_SPACE_MAXSIZE	0xFFFFFFFFFFFFFFFF
+#define	BUS_SPACE_MAXSIZE_32BIT 0xFFFFFFFFU
+#define	BUS_SPACE_MAXSIZE	0xFFFFFFFFFFFFFFFFUL
 #define	BUS_SPACE_MAXADDR_24BIT	0xFFFFFF
-#define	BUS_SPACE_MAXADDR_32BIT 0xFFFFFFFF
-#define	BUS_SPACE_MAXADDR	0xFFFFFFFF
+#define	BUS_SPACE_MAXADDR_32BIT 0xFFFFFFFFU
+#define	BUS_SPACE_MAXADDR	0xFFFFFFFFFFFFFFFFUL
 
 #define	BUS_SPACE_UNRESTRICTED	(~0)
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312151801.rBFI1IwM020208>