Date: Fri, 27 Jul 2007 14:39:02 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Rong-En Fan <rafan@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Chris Cowart <ccowart@rescomp.berkeley.edu>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net-mgmt/net-snmp4 Makefile pkg-plist ports/net-mgmt/net-snmp4/files snmpd.in snmpd.sh.sample Message-ID: <46AA65F6.2000204@FreeBSD.org> In-Reply-To: <200707271159.l6RBxTwp090951@repoman.freebsd.org> References: <200707271159.l6RBxTwp090951@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Rong-En Fan wrote: > rafan 2007-07-27 11:59:29 UTC > > FreeBSD ports repository > > Modified files: > net-mgmt/net-snmp4 Makefile pkg-plist > Added files: > net-mgmt/net-snmp4/files snmpd.in > Removed files: > net-mgmt/net-snmp4/files snmpd.sh.sample > Log: > - Convert to rc.d style script > - Bump PORTREVISION > > Note that I changed few places of the patch to match Porter's Handbook. > > PR: ports/114952 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=114952 > Submitted by: Chris Cowart <ccowart at rescomp.berkeley.edu> > > Revision Changes Path > 1.106 +2 -6 ports/net-mgmt/net-snmp4/Makefile > 1.1 +26 -0 ports/net-mgmt/net-snmp4/files/snmpd.in (new) > 1.2 +0 -20 ports/net-mgmt/net-snmp4/files/snmpd.sh.sample (dead) > 1.24 +0 -1 ports/net-mgmt/net-snmp4/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/net-snmp4/Makefile.diff?&r1=1.105&r2=1.106&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/net-snmp4/files/snmpd.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/net-snmp4/files/snmpd.sh.sample > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/net-snmp4/pkg-plist.diff?&r1=1.23&r2=1.24&f=h This looks good overall. One question, it looks like this script is starting a service, would it benefit from the shutdown KEYWORD? Doug -- This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46AA65F6.2000204>