Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 26 Aug 1999 09:48:36 -0700
From:      Mike Smith <mike@smith.net.au>
To:        Poul-Henning Kamp <phk@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/isofs/cd9660 cd9660_vfsops.c src/sys/kern vfs_subr.c vfs_syscalls.c src/sys/miscfs/devfs devfs_tree.c src/sys/miscfs/specfs spec_vnops.c src/sys/nfs nfs_subs.c src/sys/svr4 svr4_fcntl.c src/sys/sys conf.h lock.h vnode.h ... 
Message-ID:  <199908261648.JAA02354@dingo.cdrom.com>
In-Reply-To: Your message of "Thu, 26 Aug 1999 07:53:32 PDT." <199908261453.HAA58170@freefall.freebsd.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
>           Rename checkalias2() and checkalias() to addalias() and
>           addaliasu() - which takes dev_t and udev_t arg respectively.

To be consistent with eg. vput(), vcount() these should be vaddalias*
(and vn_* would be better again).

There are a lot of macros and functions with totally opaque names 
currently in use (eg. btodb); if you're on a namechanging rampage it's 
always good to try to make them less so. 8)

(Yes, I believe that this sort of feedback is more appropriate than a 
 public review of patches like these.)


-- 
\\  The mind's the standard       \\  Mike Smith
\\  of the man.                   \\  msmith@freebsd.org
\\    -- Joseph Merrick           \\  msmith@cdrom.com




To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199908261648.JAA02354>