Date: Thu, 15 Apr 2010 08:29:31 +0200 From: Luigi Rizzo <rizzo@iet.unipi.it> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, Luigi Rizzo <luigi@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, Fabio Checconi <fabio@FreeBSD.org> Subject: Re: svn commit: r206497 - in head: sbin/geom/class sbin/geom/class/sched sys/geom/sched sys/modules/geom sys/modules/geom/geom_sched sys/modules/geom/geom_sched/gs_sched sys/modules/geom/geom_sched/gsc... Message-ID: <20100415062931.GA92769@onelab2.iet.unipi.it> In-Reply-To: <20100414210117.GA2252@garage.freebsd.pl> References: <201004121637.o3CGbjSK080066@svn.freebsd.org> <20100412204926.GB1743@garage.freebsd.pl> <20100412210512.GB94885@onelab2.iet.unipi.it> <20100414074616.GA1657@garage.freebsd.pl> <20100414081630.GA74130@onelab2.iet.unipi.it> <20100414160554.GB3188@gandalf.sssup.it> <20100414210117.GA2252@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 14, 2010 at 11:01:17PM +0200, Pawel Jakub Dawidek wrote: > On Wed, Apr 14, 2010 at 06:05:54PM +0200, Fabio Checconi wrote: > > - Some classes (from a quick look I've seen only g_mirror, but I'm > > pretty sure there were some other ones) cache pointers to their > > providers. With these classes this implementation does not work. > > This can be easly changed to go though geom to provider. Many of my > classes do that. Absolutely. The above was just to explain why we only implemented insert/remove within geom_sched instead of globally. If/when we make the feature globally available, we also need to inspect all classes to make sure that there are no surprises. cheers luigi > > -- > Pawel Jakub Dawidek http://www.wheelsystems.com > pjd@FreeBSD.org http://www.FreeBSD.org > FreeBSD committer Am I Evil? Yes, I Am!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100415062931.GA92769>