Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 30 Jun 2009 14:36:05 -0600
From:      Scott Long <scottl@samsco.org>
To:        =?ISO-8859-2?Q?Piotr_Zi=EAcik?= <kosmo@semihalf.com>
Cc:        freebsd-current@freebsd.org
Subject:   Re: [PATCH RFC]: Bus_dma eats all available memory
Message-ID:  <4A4A7735.9060301@samsco.org>
In-Reply-To: <200906301529.42195.kosmo@semihalf.com>
References:  <200906251329.35200.kosmo@semihalf.com> <200906260929.40709.kosmo@semihalf.com> <4A44D4AD.8010307@samsco.org> <200906301529.42195.kosmo@semihalf.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Piotr Ziêcik wrote:
> Friday 26 June 2009 16:01:17 Scott Long napisa³(a):
>> Tags and maps should be allocated at driver initialization time, not
>> every time a request comes in.  The problem here isn't the MAX() test,
>> it's that the MIN_ALLOC_COMP test is getting fooled because the tag
>> keeps on getting recycled.  The correct fix is likely to move the flag
>> into the bounce zone object.  But in general, you should not be
>> allocating and freeing tags and maps so often, they are meant to have a
>> long lifespan.
>>
> 
> I have fixed my driver and updated patch for bus_dma. Could I ask you for 
> review ? Patch was successfully tested on ARM.
> 

This looks reasonable.  I'll give it a closer review and commit it to 
the FreeBSD repo.  Thanks a lot for working on it.

Scott



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A4A7735.9060301>