Date: Fri, 25 Jun 2004 15:21:47 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: Dag-Erling Sm?rgrav <des@des.no> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libpam/modules/pam_radius pam_radius.c Message-ID: <20040625122147.GA38746@ip.net.ua> In-Reply-To: <xzp1xk325pg.fsf@dwp.des.no> References: <200406250154.i5P1sQcp072094@repoman.freebsd.org> <xzp659g0ywd.fsf@dwp.des.no> <20040625120329.GB37003@ip.net.ua> <xzp1xk325pg.fsf@dwp.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
--h31gzZEtNLTqOjlF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Jun 25, 2004 at 02:16:27PM +0200, Dag-Erling Sm?rgrav wrote:
> Ruslan Ermilov <ru@FreeBSD.org> writes:
> > On Fri, Jun 25, 2004 at 11:28:50AM +0200, Dag-Erling Sm?rgrav wrote:
> > > Alexander Kabaev <kan@FreeBSD.org> writes:
> > > > Log:
> > > > Remove the use of cast as lvalue.
> > > This trades one style bug for another (missing space before *), breaks
> > > the build on 64-bit platforms, and violates maintainership.
> > Ah, so this commit is responsible for a cross-build breakage...
>=20
> No, this one currently only breaks Alpha because we apparently don't
> enforce alignment requirements on other platforms.
>=20
It also breaks ia64 (verified on pluto1), and probably sparc64 too (my
cross-build test broke). I restarted my sparc64 cross-build test with
the following bandaid patch for the time being:
%%%
Index: pam_radius.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /home/ncvs/src/lib/libpam/modules/pam_radius/pam_radius.c,v
retrieving revision 1.21
diff -u -p -r1.21 pam_radius.c
--- pam_radius.c 25 Jun 2004 01:54:26 -0000 1.21
+++ pam_radius.c 25 Jun 2004 12:18:16 -0000
@@ -111,7 +111,7 @@ build_access_request(struct rad_handle *
hints.ai_family =3D PF_INET;
if (getaddrinfo(nas_ipaddr, NULL, &hints, &res) =3D=3D 0 &&
res !=3D NULL) {
- haddr =3D (struct sockaddr_in*)res->ai_addr;
+ haddr =3D (struct sockaddr_in *)(void *)res->ai_addr;
error =3D rad_put_addr(radh, RAD_NAS_IP_ADDRESS,
haddr->sin_addr);
freeaddrinfo(res);
%%%
Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer
--h31gzZEtNLTqOjlF
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFA3BjbqRfpzJluFF4RAhLaAJ9nY6FQzcQiWWvQn9oJtVVzYbluKgCgisdf
nXn87xTA3a+fHOlj9N1dzzo=
=NXK+
-----END PGP SIGNATURE-----
--h31gzZEtNLTqOjlF--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040625122147.GA38746>