Date: Wed, 26 Oct 2005 13:38:17 -0700 From: "Eli K. Breen" <bsd@unixforge.net> To: Giorgos Keramidas <keramida@FreeBSD.org> Cc: freebsd-doc@FreeBSD.org Subject: Re: docs/87351: Jail building instructions don't work as described with default CSH shell Message-ID: <435FE939.6070203@unixforge.net> In-Reply-To: <200510262020.j9QKKv4Q073769@freefall.freebsd.org> References: <200510262020.j9QKKv4Q073769@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Call me madcap, but wouldn't it make more sense to have the base case example match the default shell, with exceptions for other shells as the side-comments? Given how little of this script/instructions need to change to suit csh, something like... [...] #For csh set D=/here/is/the/jail #For bourne shells (sh,bash,...) D=/here/is/the/jail cd /usr/src mkdir -p $D [...] or [...] #For csh set D=/here/is/the/jail #For bourne shells (sh,bash,...) # D=/here/is/the/jail cd /usr/src mkdir -p $D [...] The former solution is both legible and functional. If you dump it on the command-line verbatim, it will produce an error for whichever environment export didn't work, but the process overall will work, and the latter is a little cleaner, and won't produce any errors with the base shell. A happy user experience overall. -Eli Giorgos Keramidas wrote: > Synopsis: Jail building instructions don't work as described with default CSH shell > > State-Changed-From-To: open->patched > State-Changed-By: keramida > State-Changed-When: Wed Oct 26 20:18:41 GMT 2005 > State-Changed-Why: > > I've just committed a note that points to sh(1) in CURRENT. > The change will be MFC'ed in a few days. If I get approval > early enough it will even be in 6.0-RELEASE. > > Thanks for the problem report :) > > http://www.freebsd.org/cgi/query-pr.cgi?pr=87351
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?435FE939.6070203>