Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 1 Nov 2006 17:28:08 +0100 (CET)
From:      Rudolf Cejka <cejkar@fit.vutbr.cz>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   www/105026: [PATCH] Missing space between skip site and section navigation
Message-ID:  <200611011628.kA1GS8ZL087821@kazi.fit.vutbr.cz>
Resent-Message-ID: <200611011630.kA1GULl8018846@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         105026
>Category:       www
>Synopsis:       [PATCH] Missing space between skip site and section navigation
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-www
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 01 16:30:21 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Rudolf Cejka
>Release:        FreeBSD 5.3-STABLE i386
>Organization:
FIT, Brno University of Technology, Czech Republic
>Environment:
>Description:

This problem is very similar to the PR www/104925, however I think that
I have found simple and elegant solution here.

Just take a look at both http://www.FreeBSD.org/ (xsl page) and
http://www.FreeBSD.org/where.html (sgml page) in txtoffscreen mode
(basic page style in Mozilla) and compare them. There is a space
between Skip site navigation (1) and Skip section navigation (2), but
just in case of sgml sourced page. Page generated from xsl is
missing it.

I think that I have found a solution here - the patch below simply
joins two <span>...</span> blocks into one, where white space removal
does not occur in sgml nor in xsl case.

--- www/share/sgml/header.ent.orig	Wed Nov  1 17:09:57 2006
+++ www/share/sgml/header.ent	Wed Nov  1 17:10:43 2006
@@ -123,9 +123,8 @@
 <!ENTITY header2 '
 <span class="txtoffscreen"
 ><a href="#CONTENT" title="Skip site navigation" accesskey="1"
->Skip site navigation</a> (1)</span>
-<span class="txtoffscreen"
-><a href="#CONTENTWRAP" title="Skip section navigation" accesskey="2"
+>Skip site navigation</a> (1)
+<a href="#CONTENTWRAP" title="Skip section navigation" accesskey="2"
 >Skip section navigation</a> (2)</span>
 
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200611011628.kA1GS8ZL087821>