Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 2 Jan 2010 10:13:21 +0000 (UTC)
From:      Ed Schouten <ed@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r201384 - head/usr.bin/script
Message-ID:  <201001021013.o02ADLbg009385@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ed
Date: Sat Jan  2 10:13:21 2010
New Revision: 201384
URL: http://svn.freebsd.org/changeset/base/201384

Log:
  Remove a warning by adding extra parentheses.
  
  GCC generates warnings when using "if (foo = bar)". In this case its use
  is valid.

Modified:
  head/usr.bin/script/script.c

Modified: head/usr.bin/script/script.c
==============================================================================
--- head/usr.bin/script/script.c	Sat Jan  2 10:12:12 2010	(r201383)
+++ head/usr.bin/script/script.c	Sat Jan  2 10:13:21 2010	(r201384)
@@ -126,7 +126,7 @@ main(int argc, char *argv[])
 	if ((fscript = fopen(fname, aflg ? "a" : "w")) == NULL)
 		err(1, "%s", fname);
 
-	if (ttyflg = isatty(STDIN_FILENO)) {
+	if ((ttyflg = isatty(STDIN_FILENO)) != 0) {
 		if (tcgetattr(STDIN_FILENO, &tt) == -1)
 			err(1, "tcgetattr");
 		if (ioctl(STDIN_FILENO, TIOCGWINSZ, &win) == -1)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201001021013.o02ADLbg009385>