Date: Fri, 18 Dec 2009 15:10:17 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: ed@80386.nl Cc: svn-src-head@FreeBSD.org, des@des.no, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, jhb@FreeBSD.org Subject: Re: svn commit: r200606 - in head/sys: compat/freebsd32 sys Message-ID: <20091218.151017.956847443318915404.imp@bsdimp.com> In-Reply-To: <20091218163626.GF64905@hoeg.nl> References: <200912161541.53834.jhb@freebsd.org> <868wd0cyjd.fsf@ds4.des.no> <20091218163626.GF64905@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20091218163626.GF64905@hoeg.nl>
Ed Schouten <ed@80386.nl> writes:
: Hello DES,
: =
: First of all: happy birthday!
: =
: * Dag-Erling Sm=F8rgrav <des@des.no> wrote:
: > perhaps we should simply add the appropriate
: > #ifndef / #error constructs so you can't define FREEBSD_COMPAT(n)
: > without FREEBSD_COMPAT(n+1).
: =
: Why not make COMPAT_FREEBSD numerical?
: =
: | options COMPAT_FREEBSD=3D4
: =
: and let the code use:
: =
: | #if COMPAT_FREEBSD <=3D 4
: | ...
: | #endif
That would take some doing to the syscall generation code as well.
The whole concept of the compat stuff isn't well thought out, since it
seems backwards (and I think that you got your example wrong).
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091218.151017.956847443318915404.imp>